Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITK Python with MSVC++ in debug #508

Open
fbudin69500 opened this Issue Feb 14, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@fbudin69500
Copy link
Contributor

fbudin69500 commented Feb 14, 2019

ITK compiles fine with MSVC++ in Debug mode, but the Python tests are failing.

One line of code that can be improved to help with this issue is this one since currently at link time, it always uses the Release Python library. CMake Generator Expressions could be used to correct this. However, this is not enough to make the Python tests successfully pass.

@fbudin69500

This comment has been minimized.

Copy link
Contributor Author

fbudin69500 commented Feb 14, 2019

The CMake file linked above could be improve by using the following code:

itk_target_link_libraries_with_dynamic_lookup(${lib} LINK_PUBLIC $<$CONFIG:Debug:${PYTHON_DEBUG_LIBRARY}>$<$CONFIG:Release:${PYTHON_LIBRARY}>)

@blowekamp

This comment has been minimized.

Copy link
Member

blowekamp commented Feb 14, 2019

PYTHONG_DEBUG_LIBRARY is deprecated. Consider this more modern signature:

target_link_libraries(<target> LINK_INTERFACE_LIBRARIES [[debug|optimized|general] <lib>] ...)

and the following:
https://github.com/Kitware/CMake/blob/master/Modules/FindPythonLibs.cmake#L215-L217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.