Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BridgeOpenCV fails to build with OpenCV 4 #806

Open
nocnokneo opened this issue May 1, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@nocnokneo
Copy link
Contributor

commented May 1, 2019

Description

For example, when building unit tests:

C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe 
... .../ITK\Modules\Video\BridgeOpenCV\test\itkOpenCVImageBridgeGrayScaleTest.cxx
.../opencv2/imgcodecs/imgcodecs_c.h(1): fatal error C1189: #error:  "This header with legacy C API declarations has been removed from OpenCV. Legacy contants are available from legacy/constants_c.h file." 

Steps to Reproduce

  1. Build ITK against OpenCV4 4.0.1 with -DBUILD_TESTING:BOOL=ON -DModule_ITKVideoBridgeOpenCV:BOOL=ON

Versions

Latest master (b83454e)

Environment

Tested on Windows with MSVC 2015 and 2017 and Ubuntu 18.04 gcc-6

@nocnokneo nocnokneo added the type:Bug label May 1, 2019

@nocnokneo

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

I'm happy to submit a patch for this. Can OpenCV 2.x support be dropped at this point?

@dzenanz

This comment has been minimized.

Copy link
Member

commented May 1, 2019

It can probably be dropped. Let's give a few days to others to possibly raise objections.

@nocnokneo

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

@thewtex

This comment has been minimized.

Copy link
Member

commented May 7, 2019

+1 for dropping OpenCV 2.x support.

@hjmjohnson

This comment has been minimized.

Copy link
Member

commented May 7, 2019

+100 for dropping OpenCV2.x support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.