Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Resample over WarpImageFilter in Examples #809

Open
blowekamp opened this issue May 2, 2019 · 11 comments

Comments

Projects
None yet
3 participants
@blowekamp
Copy link
Member

commented May 2, 2019

These two filers apply deformation fields to images ( and vector images ). The same functionality now exist in the ResampleImageFilter.

Should these filters be deprecated to avoid confusion?

@blowekamp

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@thewtex @ntustison @hjmjohnson
Any thought on these classes?

@hjmjohnson

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@blowekamp I am in favor of deprecating as long a documentation clearly expresses how to get the same results with ResampleImageFilter (Including an example refactoring).

Thanks Brad.

@blowekamp

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

Here is list of examples which use the WarpImageFilter:

Filtering/WarpImageFilter1.cxx
RegistrationITKv3/DeformableRegistration10.cxx
RegistrationITKv3/DeformableRegistration16.cxx
RegistrationITKv3/DeformableRegistration17.cxx
RegistrationITKv3/DeformableRegistration2.cxx
RegistrationITKv3/DeformableRegistration3.cxx
RegistrationITKv3/DeformableRegistration5.cxx
RegistrationITKv3/DeformableRegistration9.cxx
RegistrationITKv3/LandmarkWarping2.cxx
RegistrationITKv4/DeformableRegistration10.cxx
RegistrationITKv4/DeformableRegistration16.cxx
RegistrationITKv4/DeformableRegistration17.cxx
RegistrationITKv4/DeformableRegistration2.cxx
RegistrationITKv4/DeformableRegistration3.cxx
RegistrationITKv4/DeformableRegistration5.cxx
RegistrationITKv4/DeformableRegistration9.cxx
RegistrationITKv4/LandmarkWarping2.cxx

Looks like step one is to update those examples to use the ResampleImageFilter.

@blowekamp

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

We need to figure out what to do with the ITKv3 Registration examples...

@hjmjohnson

This comment has been minimized.

Copy link
Member

commented May 2, 2019

The ITKv3 examples should definitely be deprecated, and I would recommend removing them (as they are now confusing to users who accidentally end up in that directory.

@hjmjohnson

This comment has been minimized.

Copy link
Member

commented May 2, 2019

On second thought, perhaps we should just move them out of the "examples" directory and into a "testing" subdirectory as they may still have code coverage utility.

ITKv6 should evaluate if the ITKv3 framework is completely removed.

@blowekamp

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

I agree that it is important to keep them as testing while we have the ITKv3 registration framework still there.

Tangentially related, ITKv4 registration framework now sounds old. Perhaps is would have been better to call the old one "legacy" registration framework, and just call the current one "the registration framework". I'm not sure how often it's called ITKv4 registration framework.

@blowekamp

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

It would take quite a bit of effort to fully remove the warp filters now. There are a number of filters still using them.

The examples are the important things to update now to just use the ResampleImageFilter. I'll try to knock these off little by little.

@hjmjohnson

This comment has been minimized.

Copy link
Member

commented May 8, 2019

It would take quite a bit of effort to fully remove the warp filters now. There are a number of filters still using them.

The examples are the important things to update now to just use the ResampleImageFilter. I'll try to knock these off little by little.

@blowekamp Thanks. I appreciate the efforts.

@blowekamp blowekamp changed the title Deprecate WarpImageFilter and WarpVectorImageFilter Use Resample over WarpImageFilter in Examples May 17, 2019

@dzenanz

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Can this now be closed? There was some work on this topic over the past month.

@blowekamp

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

There is still quite of number of examples which should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.