Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up clang macros #845

Closed
dzenanz opened this issue May 8, 2019 · 3 comments
Closed

Clean up clang macros #845

dzenanz opened this issue May 8, 2019 · 3 comments
Assignees
@seanm
Labels
Good first issue A good issue for community members new to contributing type:Compiler Compiler support or related warnings type:Style Style changes: no logic impact (indentation, comments, naming)
Milestone
ITK 6.0 Beta 1

Comments

@dzenanz
Copy link
Member

dzenanz commented May 8, 2019

#543 was mostly resolved by @maekclena. Can clang macros be simplified too?
@dzenanz dzenanz added type:Compiler Compiler support or related warnings Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming) labels May 8, 2019
@dzenanz
Copy link
Member Author

dzenanz commented Aug 18, 2021

There are more opportunities for this, now that we require at least C++14 support.

@hjmjohnson hjmjohnson added this to the ITK 6.0 Beta 1 milestone Jan 23, 2025
@hjmjohnson
Copy link
Member

@N-Dekker I think you may have addressed this already. Could you please take a look at this issue and close if you think it is completed?

@seanm seanm self-assigned this Jan 23, 2025
@seanm
Copy link
Contributor

seanm commented Jan 23, 2025

I've searched the codebase for __clang__, __GNUC__, etc. and I believe everything is 'cleaned up' as much as it can be.

@seanm seanm closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanm seanm

Labels
Good first issue A good issue for community members new to contributing type:Compiler Compiler support or related warnings type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
ITK 6.0 Beta 1
Development

No branches or pull requests
4 participants
@seanm @hjmjohnson @dzenanz @sjh26