Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDCM warnings #925

Open
SimonRit opened this issue May 21, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@SimonRit
Copy link

commented May 21, 2019

When compiling ITK with Module_RTK, I have a bunch of warnings which are related to GDCM, see the list in the following dashboard results
https://my.cdash.org/viewBuildError.php?type=1&buildid=1652539
https://my.cdash.org/viewBuildError.php?type=1&buildid=1652545
https://my.cdash.org/viewBuildError.php?type=1&buildid=1652594
Should I (1) submit a patch to fix them in ITK, (2) disable warnings in ITK for GDCM with itk_module_warnings_disable (I'm not sure what to do with the "has no symbols" warnings then) or maybe @malaterre wants to fix them both in GDCM and ITK? Thanks!

@malaterre

This comment has been minimized.

Copy link
Member

commented May 21, 2019

@SimonRit If you write a patch I can either git cherry-pick / am in GDCM if needed. Thanks

@SimonRit

This comment has been minimized.

Copy link
Author

commented May 21, 2019

Alright, I'll propose something. Can you explain empty files like gdcmItem.cxx which generate those "has no symbols" warnings? Are they necessary for some reason or can my patch remove them?

@malaterre

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Well really the warning is annoying to me. Anyway I'd prefer you move the gdcm::Item::Clear() definition to the cxx file. This should silence the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.