Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Todo items in AzimuthElevationToCartesianTransform #987

Open
hjmjohnson opened this issue Jun 1, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@hjmjohnson
Copy link
Member

commented Jun 1, 2019

Description

AzimuthElevationToCartesianTransform

  • \todo Is there any real value in allowing the user to template
  • over the scalar type? Perhaps it should always be double, unless
  • there's a compatibility problem with the Point class.
  • \todo Derive this class from TransformBase class.
  • Currently, this class derives from AffineTransform, although
  • it is not an affine transform.
  • \todo Add a figure in the documentation that informs the formulas used in this class
  • that are used to transform Cartesian to azimuth-elevation-radius

Expected behavior

Noted todo items should be removed from code base.

Actual behavior

Versions

ITK version 5.0.0

@dzenanz

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

What is this being blocked by?

@hjmjohnson

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

That was a mistake.

@maekclena

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

One thing that might be worth noting: most of the code of AzimuthElevationToCartesianTransform is duplicated in PhasedArray3DSpecialCoordinatesImage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.