Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Todo items in AzimuthElevationToCartesianTransform #987

Open
hjmjohnson opened this issue Jun 1, 2019 · 3 comments
Open

Address Todo items in AzimuthElevationToCartesianTransform #987

hjmjohnson opened this issue Jun 1, 2019 · 3 comments
Labels
Good first issue A good issue for community members new to contributing type:Design Improvement in the design of a given area

Comments

@hjmjohnson
Copy link
Member

Description

AzimuthElevationToCartesianTransform

  • \todo Is there any real value in allowing the user to template
  • over the scalar type? Perhaps it should always be double, unless
  • there's a compatibility problem with the Point class.
  • \todo Derive this class from TransformBase class.
  • Currently, this class derives from AffineTransform, although
  • it is not an affine transform.
  • \todo Add a figure in the documentation that informs the formulas used in this class
  • that are used to transform Cartesian to azimuth-elevation-radius

Expected behavior

Noted todo items should be removed from code base.

Actual behavior

Versions

ITK version 5.0.0
@hjmjohnson hjmjohnson added type:Design Improvement in the design of a given area Good first issue A good issue for community members new to contributing status:Blocked Blocked by some other issue which needs to be resolved first or by some other cause labels Jun 1, 2019
@dzenanz
Copy link
Member

dzenanz commented Jun 3, 2019

What is this being blocked by?

@hjmjohnson hjmjohnson removed the status:Blocked Blocked by some other issue which needs to be resolved first or by some other cause label Jun 3, 2019
@hjmjohnson
Copy link
Member Author

That was a mistake.

@maekclena
Copy link
Contributor

One thing that might be worth noting: most of the code of AzimuthElevationToCartesianTransform is duplicated in PhasedArray3DSpecialCoordinatesImage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue A good issue for community members new to contributing type:Design Improvement in the design of a given area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hjmjohnson @dzenanz @maekclena