Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Conditional python 3.8 code optional #2966

Merged
merged 1 commit into from
Dec 15, 2021
Merged

BUG: Conditional python 3.8 code optional #2966

merged 1 commit into from
Dec 15, 2021

Conversation

hjmjohnson
Copy link
Member

Make code imported from Python 3.8+ features an
optional testcase.

Resolves: #2963.

@github-actions github-actions bot added area:Filtering Issues affecting the Filtering module area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Dec 15, 2021
@hjmjohnson
BUG: Conditional python 3.8 code optional
fb3156d 
Make code imported from Python 3.8+ features an
optional testcase.

Resolves: InsightSoftwareConsortium#2963.
@hjmjohnson
Copy link
Member Author

Failing mac test fixed upstream.

@hjmjohnson hjmjohnson merged commit c779d09 into InsightSoftwareConsortium:master Dec 15, 2021
@hjmjohnson hjmjohnson deleted the fix-python-pre-3.8-failures branch December 15, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex Awaiting requested review from thewtex

@Leengit Leengit Awaiting requested review from Leengit

Assignees
No one assigned
Labels
area:Filtering Issues affecting the Filtering module area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.8 features used
2 participants
@hjmjohnson @dzenanz