Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on dmstr/yii2-adminlte-asset? #1

Closed
schmunk42 opened this issue Mar 4, 2015 · 3 comments
Closed

Depend on dmstr/yii2-adminlte-asset? #1

schmunk42 opened this issue Mar 4, 2015 · 3 comments

Comments

@schmunk42
Copy link
Contributor

FYI: We've a ready to use asset bundle: https://github.com/dmstr/yii2-adminlte-asset

I think about using your widgets, but I think you've some hardcoded dependencies to common?

@Insolita
Copy link
Owner

Insolita commented Mar 5, 2015

You can change dependency

     'assetManager'=>[
                 'class'=>'yii\web\AssetManager',
                 'bundles'=>[
                 //--------
                     'insolita\wgadminlte\ExtAdminlteAsset'=>[
                         'depends'=>[
                             'dmstr\web\AdminLteAsset'
                         ]
                     ]

             ],

@schmunk42
Copy link
Contributor Author

Just thought it would be helpful for you, if you could depend on an existing available bundle.
Please close this ticket if it does not apply.

@Insolita
Copy link
Owner

Insolita commented Mar 6, 2015

I really not see reason for set dependency of any Adminlte asset bundle, or make own. ExtAdminlteAsset provide script for remember collapsing state, and has a positional dependency only, and you easily change it via the assetManager. I can only remove hardcode dependecy of common\assets\AdminLTE

Repository owner locked and limited conversation to collaborators Mar 6, 2015
Repository owner unlocked this conversation Mar 6, 2015
@Insolita Insolita closed this as completed Mar 6, 2015
Insolita pushed a commit that referenced this issue Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants