docs(jobs): fix stale money-path + quota comments (terminate endpoint live, Team not unlimited)#97
Merged
Conversation
… live, Team not unlimited) Three agent-misleading comment inaccuracies in two job files. Comment-only — zero behavior change; `go build ./internal/jobs/` + `go vet` clean. payment_grace_terminator.go: - Header said terminate "(b) downgrade tier to ANONYMOUS" — the api endpoint downgrades to FREE (api internal_terminate.go:207, "anonymous would be wrong"); a terminated team keeps its team_id so free is the correct floor. - The TODO claimed the api side "is referenced by this dispatcher but NOT yet implemented in the api repo — that side ships in a separate PR." It IS implemented and live: api router.go:893 → internal_terminate.go::Terminate (pause-resources + downgrade-to-free + mark-grace-terminated + audit-emit). An agent reading the TODO would wrongly conclude dunning-termination is a no-op. Rewritten to describe the live state. quota_wall_nudge.go: - Skip-rationale said "team tier is unlimited on every axis." False post the strict-≥80%-margin redesign (2026-06-05) which retired all -1 limits — Team now carries finite high-capacity caps. Skipping Team is still correct (it's the top self-serve tier; the wall nudge is an UPGRADE banner with nothing above to upsell), so this is a stale-reason fix, not a behavior change. Verified the one local integration-test failure (TestIntegration_BillingReconciler_SkipsTestCohort) reproduces IDENTICALLY on clean origin/master without this diff — it is a pre-existing local-test-DB seed flake unrelated to these comment edits (the authoritative gate is CI's seeded postgres service). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three agent-misleading comment inaccuracies in two job files. Comment-only — zero behavior change (
go build ./internal/jobs/+go vetclean; no executable lines touched → 100%-patch gate vacuously satisfied).payment_grace_terminator.goapi internal_terminate.go:207, explicit comment "anonymous would be wrong") — a terminated team keeps itsteam_id, sofree(claimed-but-unpaid) is the correct floor.api router.go:893→internal_terminate.go::Terminatedoes pause-resources + downgrade-to-free + mark-grace-terminated + audit-emit. An agent reading the TODO would wrongly conclude the dunning-termination flow is a no-op. Rewritten to describe the live state.quota_wall_nudge.go-1limits — Team now carries finite high-capacity caps. Skipping Team is still correct (top self-serve tier; the wall nudge is an UPGRADE banner with nothing above to upsell), so this is a stale-reason fix, not a behavior change.Evidence
api/internal/router/router.go:893registersPOST /internal/teams/:id/terminate;internal_terminate.go::Terminate(line ~207) doesUpdatePlanTier(..., "free")+ resource pause + grace-row flip + audit.api/plans.yaml: Team is finite post-strict-80 (e.g. redis 1536 MB, mongodb 40960 MB) — no-1.Verification note
The single local integration-test failure (
TestIntegration_BillingReconciler_SkipsTestCohort) was confirmed to reproduce identically on clean origin/master without this diff — it is a pre-existing local-test-DB seed flake unrelated to these comment edits. The authoritative gate is CI's seeded postgres service.Memory:
feedback_display_detail_accuracy_everywhere.🤖 Generated with Claude Code