From e1fb48c80de96d84071d2cd9c885a21e11fa8015 Mon Sep 17 00:00:00 2001 From: David Mina Date: Mon, 13 Jun 2022 14:54:43 +0200 Subject: [PATCH 1/4] Bump iOS SDK to v11.0.2 --- ios/instabug_flutter.podspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ios/instabug_flutter.podspec b/ios/instabug_flutter.podspec index 9e4b545e5..541a2d973 100644 --- a/ios/instabug_flutter.podspec +++ b/ios/instabug_flutter.podspec @@ -15,7 +15,7 @@ A new flutter plugin project. s.source_files = 'Classes/**/*' s.public_header_files = 'Classes/**/*.h' s.dependency 'Flutter' - s.dependency 'Instabug', '10.13.0' + s.dependency 'Instabug', '11.0.2' s.ios.deployment_target = '10.0' s.pod_target_xcconfig = { 'OTHER_LDFLAGS' => '-framework "Flutter" -framework "Instabug"'} From c6911e0af97b1214b7468df7e5a4629e04ca4534 Mon Sep 17 00:00:00 2001 From: David Mina Date: Mon, 13 Jun 2022 14:59:05 +0200 Subject: [PATCH 2/4] Update `Surveys.hasRespondedToSurvey` on iOS --- ios/Classes/InstabugFlutterPlugin.m | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ios/Classes/InstabugFlutterPlugin.m b/ios/Classes/InstabugFlutterPlugin.m index f5e1abac1..aa7071242 100644 --- a/ios/Classes/InstabugFlutterPlugin.m +++ b/ios/Classes/InstabugFlutterPlugin.m @@ -649,9 +649,10 @@ + (void)showSurveyWithToken:(NSString *)surveyToken { * @return the desired value of whether the user has responded to the survey or not. */ + (void)hasRespondedToSurveyWithToken:(NSString *)surveyToken { - bool hasResponded = [IBGSurveys hasRespondedToSurveyWithToken:surveyToken]; - NSNumber *boolNumber = [NSNumber numberWithBool:hasResponded]; - [channel invokeMethod:@"hasRespondedToSurveyCallback" arguments:boolNumber]; + [IBGSurveys hasRespondedToSurveyWithToken:surveyToken completionHandler:^(BOOL hasResponded){ + NSNumber *boolNumber = [NSNumber numberWithBool:hasResponded]; + [channel invokeMethod:@"hasRespondedToSurveyCallback" arguments:boolNumber]; + }]; } /** @@ -1052,8 +1053,6 @@ + (NSDictionary *)constants { @"CustomTextPlaceHolderKey.conversationsListTitle": kIBGChatsTitleStringName, @"CustomTextPlaceHolderKey.audioRecordingPermissionDenied": kIBGAudioRecordingPermissionDeniedTitleStringName, @"CustomTextPlaceHolderKey.conversationTextFieldHint": kIBGChatReplyFieldPlaceholderStringName, - @"CustomTextPlaceHolderKey.bugReportHeader": kIBGReportBugStringName, - @"CustomTextPlaceHolderKey.feedbackReportHeader": kIBGReportFeedbackStringName, @"CustomTextPlaceHolderKey.voiceMessagePressAndHoldToRecord": kIBGRecordingMessageToHoldTextStringName, @"CustomTextPlaceHolderKey.voiceMessageReleaseToAttach": kIBGRecordingMessageToReleaseTextStringName, @"CustomTextPlaceHolderKey.reportSuccessfullySent": kIBGThankYouAlertMessageStringName, From 650609cb2d0a28b85b1b3ae670923632505999a9 Mon Sep 17 00:00:00 2001 From: David Mina Date: Mon, 13 Jun 2022 15:01:56 +0200 Subject: [PATCH 3/4] Bump Android SDK to v11.2.0 --- android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index 58ba49254..8341bebbd 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -34,7 +34,7 @@ android { } } dependencies { - implementation 'com.instabug.library:instabug:10.13.0' + implementation 'com.instabug.library:instabug:11.2.0' testImplementation 'junit:junit:4.12' } From 5e67baf213ac84cdc812f4c8625255c7263413bc Mon Sep 17 00:00:00 2001 From: David Mina Date: Mon, 13 Jun 2022 15:12:19 +0200 Subject: [PATCH 4/4] Remove bugReportHeader & feedbackReportHeader keys Use reportBug & reportFeedback instead --- .../main/java/com/instabug/instabugflutter/ArgsRegistry.java | 2 -- .../java/com/instabug/instabugflutter/ArgsRegistryTest.java | 4 ---- lib/Instabug.dart | 2 -- 3 files changed, 8 deletions(-) diff --git a/android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java b/android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java index 7330254b1..debf8975d 100644 --- a/android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java +++ b/android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java @@ -175,8 +175,6 @@ static void registerCustomTextPlaceHolderKeysArgs(Map args) { args.put("CustomTextPlaceHolderKey.conversationsListTitle", InstabugCustomTextPlaceHolder.Key.CONVERSATIONS_LIST_TITLE); args.put("CustomTextPlaceHolderKey.audioRecordingPermissionDenied", InstabugCustomTextPlaceHolder.Key.AUDIO_RECORDING_PERMISSION_DENIED); args.put("CustomTextPlaceHolderKey.conversationTextFieldHint", InstabugCustomTextPlaceHolder.Key.CONVERSATION_TEXT_FIELD_HINT); - args.put("CustomTextPlaceHolderKey.bugReportHeader", InstabugCustomTextPlaceHolder.Key.BUG_REPORT_HEADER); - args.put("CustomTextPlaceHolderKey.feedbackReportHeader", InstabugCustomTextPlaceHolder.Key.FEEDBACK_REPORT_HEADER); args.put("CustomTextPlaceHolderKey.voiceMessagePressAndHoldToRecord", InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD); args.put("CustomTextPlaceHolderKey.voiceMessageReleaseToAttach", InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_RELEASE_TO_ATTACH); args.put("CustomTextPlaceHolderKey.reportSuccessfullySent", InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT); diff --git a/android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java b/android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java index 8c17bb4eb..9e7771196 100644 --- a/android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java +++ b/android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java @@ -267,8 +267,6 @@ private List getCurrentlySupportedKeysBySDK() keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATIONS_LIST_TITLE); keys.add(InstabugCustomTextPlaceHolder.Key.AUDIO_RECORDING_PERMISSION_DENIED); keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATION_TEXT_FIELD_HINT); - keys.add(InstabugCustomTextPlaceHolder.Key.BUG_REPORT_HEADER); - keys.add(InstabugCustomTextPlaceHolder.Key.FEEDBACK_REPORT_HEADER); keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD); keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_RELEASE_TO_ATTACH); keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT); @@ -307,8 +305,6 @@ private List getAllCustomTextPlaceHolderKeys( keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATIONS_LIST_TITLE); keys.add(InstabugCustomTextPlaceHolder.Key.AUDIO_RECORDING_PERMISSION_DENIED); keys.add(InstabugCustomTextPlaceHolder.Key.CONVERSATION_TEXT_FIELD_HINT); - keys.add(InstabugCustomTextPlaceHolder.Key.BUG_REPORT_HEADER); - keys.add(InstabugCustomTextPlaceHolder.Key.FEEDBACK_REPORT_HEADER); keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD); keys.add(InstabugCustomTextPlaceHolder.Key.VOICE_MESSAGE_RELEASE_TO_ATTACH); keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT); diff --git a/lib/Instabug.dart b/lib/Instabug.dart index fe6352bd2..ef6311855 100644 --- a/lib/Instabug.dart +++ b/lib/Instabug.dart @@ -67,8 +67,6 @@ enum CustomTextPlaceHolderKey { conversationsListTitle, audioRecordingPermissionDenied, conversationTextFieldHint, - bugReportHeader, - feedbackReportHeader, voiceMessagePressAndHoldToRecord, voiceMessageReleaseToAttach, reportSuccessfullySent,