Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
@cdoncarroll It's not a bad API, but
I whipped up a sample project illustrating a few of these ideas: UICollectionViewDeselection.zip
Where you have
Also you have to override
Putting this all together, we end up reimplementing the selection API and introduce some weird
In the end we do a lot of complicated things and possibly introduce some weird behavior all to save clients tracking state themselves, which shouldn't be hard.
@kronik I'll make sure to get an example up, but for now probably manually tracking selection in the section controllers. The trickier part is then getting a list of selected stuff. There are two options that I've seen work:
I'd probably go w/ the first option.
However @cdoncarroll and I were chatting a lot last week about this and we might try to find a way to bake support into IGListKit, but to fully support selection it'll be a bigger change, so nothing concrete planned.
Summary: Adding support for a cell deselection API. Trying to make some headway to move and drag+drop support, but also want better stock `UICollectionView` API support. Will also assist eventual `UITableView` support. - Added overridable API to `IGListSectionController` - Support for stacked SC - Breaking, required protocol for binding SC Assists #524 and #184 - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes #853 Reviewed By: jeremycohen Differential Revision: D5425414 Pulled By: rnystrom fbshipit-source-id: 0b25c125b1f171979a15c3095095fc18b4108be6