Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Change Instagram.respond_to? signature #122

Merged
merged 1 commit into from

5 participants

@be9
be9 commented

Ruby 1.9 and 2.0 allow Object#respond_to? to receive two arguments:

respond_to?(symbol, include_all=false)

Current signature with only one argument makes trouble when using rspec 3.0 to mock Instagram class behavior.

@be9 be9 Change Instagram.respond_to? signature
Ruby 1.9 and 2.0 allow Object#respond_to? to receive two arguments:

respond_to?(symbol, include_all=false)
9bbf7af
@facebook-github-bot

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@be9
be9 commented

Signed up.

@facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tagliala

@be9 I also ran into this issue: rspec/rspec-rails#1066

Please take a look at the following comment: rspec/rspec-rails#1066 (comment)

@brain-geek

Also ran into this issue.
Any chance of merging this fix?

@heatonjb heatonjb merged commit 3c9dd74 into Instagram:master
@heatonjb
Owner

Merged and released to Ruby Gems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 5, 2014
  1. @be9

    Change Instagram.respond_to? signature

    be9 authored
    Ruby 1.9 and 2.0 allow Object#respond_to? to receive two arguments:
    
    respond_to?(symbol, include_all=false)
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/instagram.rb
View
4 lib/instagram.rb
@@ -21,7 +21,7 @@ def self.method_missing(method, *args, &block)
end
# Delegate to Instagram::Client
- def self.respond_to?(method)
- return client.respond_to?(method) || super
+ def self.respond_to?(method, include_all=false)
+ return client.respond_to?(method, include_all) || super
end
end
Something went wrong with that request. Please try again.