Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idmtools package should not include the tests folder. #2298

Closed
YeChen-IDM opened this issue Jun 11, 2024 · 2 comments
Closed

idmtools package should not include the tests folder. #2298

YeChen-IDM opened this issue Jun 11, 2024 · 2 comments
Assignees

Comments

@YeChen-IDM
Copy link
Collaborator

When I install the emodpy package which install the idmtools package as a dependency. I got a tests folder in my site-packages folder. The tests are treated as a module:

image
I can import the tests scripts:

image
This test is from idmtools package.

I think this may be a common issue in our python packages. We will need to check other emodpy related packages too.

@shchen-idmod
Copy link
Collaborator

We have packages=find_packages(exclude=["tests"]) in few package's setp.py file, but not in all packages. I will add it to all setup.py. Thanks for catching up this error

shchen-idmod added a commit to shchen-idmod/idmtools-1 that referenced this issue Jun 11, 2024
@ZDu-IDM ZDu-IDM added this to the EMOD 2.0 Container Support milestone Jun 13, 2024
ZDu-IDM added a commit that referenced this issue Jul 9, 2024
Fix #2298 and remove python3.7 support
@shchen-idmod
Copy link
Collaborator

Fixed in 1.7.11 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants