Fix passthru copy when input X2RGB10 #2268
Conversation
AntonGrishin
requested review from
dmitryermilov,
dvrogozh,
varistar and
a team
as code owners
AntonGrishin
force-pushed
the
a2rgb10_features
branch
from
c01dbf5
to
ee260cf
Compare
_studio/shared/src/libmfx_core.cpp
Outdated
| case MFX_FOURCC_A2RGB10: | ||
| roi.width *= 4; | ||
|
|
||
| sts = FastCopy::Copy(pDst->Data.B, dstPitch, pSrc->Data.B, srcPitch, roi, copyFlag); |
There was a problem hiding this comment.
why we will receive nullptr in case of a2rgb? shouldn't all 4 pointer (Data.A, Data.R, Data.G, Data.B) pointing to exactly same location?
There was a problem hiding this comment.
Saying this I'm referring to our doc, which says "The application has to specify pointers to all color channels even for packed formats. For example, for YUY2 format the application has to specify Y, U and V pointers. For RGB32 – R, G, B and A pointers." @dmitryermilov @onabiull your thoughts?
There was a problem hiding this comment.
@mgonchar this is good point, thanks!
nullptr received because FFmpeg would like to work with "a2rgb10 (b)" pointer. But if this specified in our man, we can refer to this.
If so, then it will be enough to add support for x2rgb10.
FFmpeg uses x2rgb10 format, which matches to VA X2R10G10B10 and MFX a2rgb10 formats cmd to check: ./ffmpeg -hwaccel qsv -v verbose -c:v hevc_qsv -i \ ../p010.h265 -vf scale_qsv=format=x2rgb10,hwdownload,format=x2rgb10 \ -vframes 1 out.yuv -y fixes: Intel-Media-SDK#1654
AntonGrishin
force-pushed
the
a2rgb10_features
branch
from
ee260cf
to
ac41047
Compare
AntonGrishin
changed the title
FFmpeg uses x2rgb10 format, which matches to VA X2R10G10B10 and
MFX a2rgb10 formats
cmd to check:
./ffmpeg -hwaccel qsv -v verbose -c:v hevc_qsv -i
../p010.h265 -vf scale_qsv=format=x2rgb10,hwdownload,format=x2rgb10
-vframes 1 out.yuv -y
fixes: #1654