Skip to content

Conversation

@joserochh
Copy link
Contributor

@joserochh joserochh commented Jul 10, 2025

Proposed changes

This PR completes the format fixes on the linker module.

Types of changes

What types of changes does your code introduce to the Encrypted Computing SDK project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you are unsure about any of them, do not hesitate to ask. We are
here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING agreement
  • Current formatting and unit tests / base functionality passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Details

  • Fixes for pylint and mypy errors
  • Copyright/License header addition
  • Docstring reformatting for Doxygen

@joserochh joserochh changed the title Complete format fixes on Liinker Complete format fixes on Linker Jul 10, 2025
@joserochh joserochh marked this pull request as ready for review July 10, 2025 21:11
@joserochh joserochh changed the title Complete format fixes on Linker [hec-assembler]: Complete format fixes on Linker Jul 10, 2025
@faberga
Copy link
Collaborator

faberga commented Jul 14, 2025

HI @joserochh ,
Can you fill in the type of changes in the template, pls?
Other than that it looks good.

Copy link
Collaborator

@kylanerace kylanerace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, formatting, proper header, etc.

@joserochh joserochh merged commit dee868d into main Jul 14, 2025
7 checks passed
@joserochh joserochh deleted the joserochh/complete_linker_reformat branch July 14, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants