From 30b35ba04edad22499ba0a948708297684a94d80 Mon Sep 17 00:00:00 2001 From: Nikita Grigorian Date: Wed, 13 Aug 2025 14:14:07 -0700 Subject: [PATCH] remove anonymous namespaces from header files fixes last remaining instances of this antipattern --- dpctl/memory/_opaque_smart_ptr.hpp | 6 +++--- .../source/sorting/rich_comparisons.hpp | 16 ++++++++-------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/dpctl/memory/_opaque_smart_ptr.hpp b/dpctl/memory/_opaque_smart_ptr.hpp index d218096caa..5821cf87a7 100644 --- a/dpctl/memory/_opaque_smart_ptr.hpp +++ b/dpctl/memory/_opaque_smart_ptr.hpp @@ -39,7 +39,7 @@ #include #include -namespace +namespace detail { class USMDeleter @@ -65,11 +65,11 @@ class USMDeleter ::sycl::context _context; }; -} // end of anonymous namespace +} // namespace detail void *OpaqueSmartPtr_Make(void *usm_ptr, const sycl::queue &q) { - USMDeleter _deleter(q); + detail::USMDeleter _deleter(q); auto sptr = new std::shared_ptr(usm_ptr, std::move(_deleter)); return reinterpret_cast(sptr); diff --git a/dpctl/tensor/libtensor/source/sorting/rich_comparisons.hpp b/dpctl/tensor/libtensor/source/sorting/rich_comparisons.hpp index 2aaa1cfafa..607e916c5f 100644 --- a/dpctl/tensor/libtensor/source/sorting/rich_comparisons.hpp +++ b/dpctl/tensor/libtensor/source/sorting/rich_comparisons.hpp @@ -34,7 +34,7 @@ namespace tensor namespace py_internal { -namespace +namespace detail { template struct ExtendedRealFPLess { @@ -103,30 +103,30 @@ inline constexpr bool is_fp_v = (std::is_same_v || std::is_same_v || std::is_same_v); -} // end of anonymous namespace +} // end of namespace detail template struct AscendingSorter { - using type = std::conditional_t, - ExtendedRealFPLess, + using type = std::conditional_t, + detail::ExtendedRealFPLess, std::less>; }; template struct AscendingSorter> { - using type = ExtendedComplexFPLess>; + using type = detail::ExtendedComplexFPLess>; }; template struct DescendingSorter { - using type = std::conditional_t, - ExtendedRealFPGreater, + using type = std::conditional_t, + detail::ExtendedRealFPGreater, std::greater>; }; template struct DescendingSorter> { - using type = ExtendedComplexFPGreater>; + using type = detail::ExtendedComplexFPGreater>; }; } // end of namespace py_internal