-
Notifications
You must be signed in to change notification settings - Fork 23
dpnp.where() doesn`t work with 1 argument #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antonwolfy
merged 8 commits into
IntelPython:master
from
vlad-perevezentsev:fix_where_operator
Mar 6, 2023
Merged
dpnp.where() doesn`t work with 1 argument #1326
antonwolfy
merged 8 commits into
IntelPython:master
from
vlad-perevezentsev:fix_where_operator
Mar 6, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
reviewed
Mar 3, 2023
antonwolfy
reviewed
Mar 3, 2023
antonwolfy
reviewed
Mar 3, 2023
Contributor
|
LGTM from quickly browsing through the code. |
Contributor
Author
|
LGTM! |
antonwolfy
reviewed
Mar 5, 2023
358c67a to
7ad9733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
whereoperator supports passing a singleconditionargument and repeats the behavior of numpy.where() with a single argument by callingdpnp.nonzero()Also adds
booltype support fornon_zerofunctions.This PR is fixing issue reported in #1242