Skip to content

Clean up the list of comments with ndarray methods #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 11, 2025
Merged

Clean up the list of comments with ndarray methods #2661

merged 8 commits into from
Nov 11, 2025

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 10, 2025 •
edited
Loading

The PR cleans up a list of the commented special class method for dpnp.ndarray which are not planning to be implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Nov 10, 2025
@antonwolfy antonwolfy changed the title Clean up the list of ndarray methods as comments Clean up the list of comments with ndarray methods Nov 10, 2025
@antonwolfy antonwolfy added this to the 0.20.0 release milestone Nov 10, 2025
@antonwolfy antonwolfy marked this pull request as ready for review November 10, 2025 19:19
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Array API standard conformance tests for dpnp=0.20.0dev0=py313h509198e_46 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2025

Coverage Status

coverage: 81.401%. remained the same
when pulling e008d5c on align-list-of-ndarray-methods-with-numpy
into aec0164 on master.

vlad-perevezentsev
vlad-perevezentsev approved these changes Nov 11, 2025
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit c9afa82 into master Nov 11, 2025
101 of 103 checks passed
@antonwolfy antonwolfy deleted the align-list-of-ndarray-methods-with-numpy branch November 11, 2025 13:43
github-actions bot added a commit that referenced this pull request Nov 11, 2025
@github-actions
Clean up the list of comments with ndarray methods (#2661)
32e5806 
The PR cleans up a list of the commented special class method for
`dpnp.ndarray` which are not planning to be implemented. c9afa82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @coveralls @vlad-perevezentsev