This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Series.dropna scalable draft #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1e-to
commented
Feb 14, 2020
1e-to
commented
sdc/functions/numpy_like.py
Outdated
| return nanprod_impl | ||
|
|
||
|
|
||
| def get_pool_size(): |
Collaborator
There was a problem hiding this comment.
Let's move this file to something like prange_utils.py
sdc/functions/numpy_like.py
Outdated
| if pool_size == 0: | ||
| pool_size = get_pool_size() | ||
|
|
||
| chunk_size = size//pool_size + 1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| chunk_size = size//pool_size + 1 | |
| chunk_size = (size - 1)//pool_size + 1 |
this is the correct formula
added 2 commits
February 17, 2020 10:58
sdc/utilities/prange_utils.py
Outdated
| if pool_size == 0: | ||
| pool_size = get_pool_size() | ||
|
|
||
| chunk_size = size//pool_size + 1 |
Collaborator
There was a problem hiding this comment.
(size - 1)//pool_size + 1
sdc/functions/numpy_like.py
Outdated
| result_index = numpy.empty(shape=length, dtype=dtype_idx) | ||
| for i in prange(len(chunks)): | ||
| chunk = chunks[i] | ||
| if i == 0: |
Collaborator
There was a problem hiding this comment.
new_start = sum(arr_len[0:i])
new_stop = new_start + arr_len[i]
sdc/functions/numpy_like.py
Outdated
| for j in range(chunk.start, chunk.stop): | ||
| if new_start < new_stop: | ||
| if not isnan(arr[j]): | ||
| result_data[new_start] = arr[j] |
Collaborator
There was a problem hiding this comment.
It is better to introduce new variable. Something like current_pos. Like this:
current_pos = new_start
for j in range(chunk.start, chunk.stop):
if current_pos < new_stop:
if not isnan(arr[j]):
result_data[current_pos] = arr[j]
result_index[current_pos] = idx[j]
current_pos += 1It is confusing that you are always writing to new_start
sdc/functions/numpy_like.py
Outdated
| new_stop = new_start + arr_len[i] | ||
|
|
||
| for j in range(chunk.start, chunk.stop): | ||
| if new_start < new_stop: |
Collaborator
There was a problem hiding this comment.
Not sure if you actually need this condition
Collaborator
|
conflicts |
Collaborator
|
Could you please remeasure performance? |
Contributor
Author
It's still like in a picture one: |
PokhodenkoSA
approved these changes
Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.