This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Add PositionalIndex and EmptyIndex types and align indexes API #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: removing types.None as representation of default pd.RangeIndex created when index=None is used in DF and Series ctors, that requires most of Series and DF implementations to branch basing on index types. Instead all Series and DF functions should use common indexes API aligned to pandas one. Changed in this PR: - types.None index is removed; - Added EmptyIndexType (instead types.None index) to represent empty pandas index with dtype='Object' i.e. pd.Index([]); - Added PositionalIndexType as a replacement for types.None index for non-empty DFs and Series; - Changed unboxing of RangeIndex objects to either RangeIndexType of PositionalIndexType depending on whether it's default range or not; - Changed fix_df_index and dataframe_constructor.py to create EmptyIndexType or other index depending on whether tuple of columns is empty; - Moved implementations for index types from common and numpy_like functions to specific index files; - Updated operators and other Series methods implementations to avoid branching on index types and used index objects API instead; - Reorganized index tests and added tests verifying specific function (e.g. series reindexing) for all types of indexes.
kozlov-alexey
force-pushed
the
feature/add_more_index_types
branch
from
8dc72a5 to
013b180
Compare
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-01 21:33:47 UTC |
kozlov-alexey
force-pushed
the
feature/add_more_index_types
branch
from
2b9c725 to
c09be09
Compare
kozlov-alexey
force-pushed
the
feature/add_more_index_types
branch
from
6137f3e to
098d26e
Compare
Contributor
Author
|
@AlexanderKalistratov Can you please approve so we can finally merge this? |
AlexanderKalistratov
approved these changes
Apr 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: removing types.None as representation of default pd.RangeIndex
created when index=None is used in DF and Series ctors, that requires
most of Series and DF implementations to branch basing on index types.
Instead all Series and DF functions should use common indexes API
aligned to pandas one.
Changed in this PR:
pandas index with dtype='Object' i.e. pd.Index([]);
non-empty DFs and Series;
PositionalIndexType depending on whether it's default range or not;
EmptyIndexType or other index depending on whether tuple of columns is empty;
numpy_like functions to specific index files;
branching on index types and used index objects API instead;
(e.g. series reindexing) for all types of indexes.