Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions conda-recipe/bld.bat
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,11 @@ echo on

"%PYTHON%" setup.py build install --single-version-externally-managed --record=record.txt
if errorlevel 1 exit 1

rem Build wheel package
if NOT "%WHEELS_OUTPUT_FOLDER%"=="" (
%PYTHON% setup.py bdist_wheel
if errorlevel 1 exit 1
copy dist\sdc*.whl %WHEELS_OUTPUT_FOLDER%
if errorlevel 1 exit 1
)
18 changes: 17 additions & 1 deletion conda-recipe/build.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
set -ex

MACOSX_DEPLOYMENT_TARGET=10.9 \
if [ `uname` == Darwin ]; then
WHEELS_BUILD_ARGS=""
export MACOSX_DEPLOYMENT_TARGET=10.9
else
if [ "$CONDA_PY" == "36" ]; then
WHEELS_BUILD_ARGS="-p manylinux1_x86_64"
else
WHEELS_BUILD_ARGS="-p manylinux2014_x86_64"
fi
fi

$PYTHON setup.py build install --single-version-externally-managed --record=record.txt

# Build wheel package
if [ -n "${WHEELS_OUTPUT_FOLDER}" ]; then
$PYTHON setup.py bdist_wheel ${WHEELS_BUILD_ARGS}
cp dist/sdc*.whl ${WHEELS_OUTPUT_FOLDER}
fi
21 changes: 1 addition & 20 deletions conda-recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,12 @@ build:
number: {{ GIT_DESCRIBE_NUMBER|int }}
script_env:
- SDC_CONFIG_PIPELINE_SDC
- WHEELS_OUTPUT_FOLDER

requirements:
build:
- {{ compiler('c') }} # [not osx]
- {{ compiler('cxx') }} # [not osx]
- wheel
- python
- numba {{ NUMBA_VERSION }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numba recently became a build dependency for sdc, so it's better to keep it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep numba here


host:
Expand All @@ -45,24 +44,6 @@ test:
imports:
- sdc

outputs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to remove 'outputs' section at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the purpose of this PR is to align wheels build procedure with others packages.
Here was used conda output - it does not suits for us due to we cannot set additional arguments for wheels build.
That is why output section is removed and wheel build lines are added in build.sh and bld.bat

- type: conda
name: sdc
- type: wheel
name: sdc
requirements:
build:
- {{ compiler('c') }} # [not osx]
- {{ compiler('cxx') }} # [not osx]
- python
- wheel
- setuptools
- numba {{ NUMBA_VERSION }}
- numpy
- pandas {{ PANDAS_VERSION }}
- pyarrow {{ PYARROW_VERSION }}
- tbb-devel

about:
home: https://github.com/IntelPython/sdc
license: BSD-2-Clause
Expand Down