This repository was archived by the owner on Feb 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Update wheels build + Update linux build tag for wheels #954
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9265062
Update wheels build + Update linux build tag for wheels
Vyacheslav-Smirnov 4f4bb52
Merge branch 'gold/2021' into update_linux_wheel_build_tag
Vyacheslav-Smirnov be90a97
Put numba back to build deps
Vyacheslav-Smirnov bf43883
Merge branch 'update_linux_wheel_build_tag' of https://github.com/Int…
Vyacheslav-Smirnov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,20 @@ | ||
| set -ex | ||
|
|
||
| MACOSX_DEPLOYMENT_TARGET=10.9 \ | ||
| if [ `uname` == Darwin ]; then | ||
| WHEELS_BUILD_ARGS="" | ||
| export MACOSX_DEPLOYMENT_TARGET=10.9 | ||
| else | ||
| if [ "$CONDA_PY" == "36" ]; then | ||
| WHEELS_BUILD_ARGS="-p manylinux1_x86_64" | ||
| else | ||
| WHEELS_BUILD_ARGS="-p manylinux2014_x86_64" | ||
| fi | ||
| fi | ||
|
|
||
| $PYTHON setup.py build install --single-version-externally-managed --record=record.txt | ||
|
|
||
| # Build wheel package | ||
| if [ -n "${WHEELS_OUTPUT_FOLDER}" ]; then | ||
| $PYTHON setup.py bdist_wheel ${WHEELS_BUILD_ARGS} | ||
| cp dist/sdc*.whl ${WHEELS_OUTPUT_FOLDER} | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,13 +13,12 @@ build: | |
| number: {{ GIT_DESCRIBE_NUMBER|int }} | ||
| script_env: | ||
| - SDC_CONFIG_PIPELINE_SDC | ||
| - WHEELS_OUTPUT_FOLDER | ||
|
|
||
| requirements: | ||
| build: | ||
| - {{ compiler('c') }} # [not osx] | ||
| - {{ compiler('cxx') }} # [not osx] | ||
| - wheel | ||
| - python | ||
| - numba {{ NUMBA_VERSION }} | ||
|
|
||
| host: | ||
|
|
@@ -45,24 +44,6 @@ test: | |
| imports: | ||
| - sdc | ||
|
|
||
| outputs: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why to remove 'outputs' section at all?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. One of the purpose of this PR is to align wheels build procedure with others packages. |
||
| - type: conda | ||
| name: sdc | ||
| - type: wheel | ||
| name: sdc | ||
| requirements: | ||
| build: | ||
| - {{ compiler('c') }} # [not osx] | ||
| - {{ compiler('cxx') }} # [not osx] | ||
| - python | ||
| - wheel | ||
| - setuptools | ||
| - numba {{ NUMBA_VERSION }} | ||
| - numpy | ||
| - pandas {{ PANDAS_VERSION }} | ||
| - pyarrow {{ PYARROW_VERSION }} | ||
| - tbb-devel | ||
|
|
||
| about: | ||
| home: https://github.com/IntelPython/sdc | ||
| license: BSD-2-Clause | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numba recently became a build dependency for sdc, so it's better to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's keep numba here