This repository was archived by the owner on Feb 2, 2024. It is now read-only.
Update compiler dialect flags to use C++17 #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlov-alexey
force-pushed
the
debug/migrate_cxx17
branch
from
35fc0a2 to
9ba9215
Compare
kozlov-alexey
force-pushed
the
debug/migrate_cxx17
branch
2 times, most recently
from
4470e22 to
a2bd809
Compare
|
Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-11-13 16:50:16 UTC |
kozlov-alexey
force-pushed
the
debug/migrate_cxx17
branch
4 times, most recently
from
6163d9a to
f343f83
Compare
Details: using multiple channels (main, anaconda, conda-forge) in a conda build, causes older version of kernel-headers_linux-64 to be resolved, as newer version fails dependency resolution to meet glibc >=2.17 requirement (that seems to be deps resolution problem). As a result 'old' system headers used together with c++17 flag leads to broken build due to not declared '::timespec_get' in ctime.h.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: need C++17 features in native extensions.