Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment 4 #82

Closed
wants to merge 11 commits into from
Closed

Conversation

@GamerBah
Copy link

GamerBah commented Feb 4, 2020

Status Badge doesn't seem to want to work

Keboo and others added 11 commits Jan 6, 2020
@GamerBah GamerBah marked this pull request as ready for review Feb 5, 2020
@Cooperwutzke

This comment has been minimized.

Copy link

Cooperwutzke commented Feb 6, 2020

Will Review!

Copy link

Cooperwutzke left a comment

Assignment 4

WebAPI Analyzers enabled ✔
DI properly configured
    Services properly registered with correct scopes ✔
    DB context properly registered ✔
    AutoMapper properly registered ✔
NSwag properly setup ✔
API controllers properly expose CRUD operations ✔
Controllers are all unit tested ✔

Extra Credit

Unit tests in EntityServiceTests fixed approprietly ❌
Mocking framework used to create the test doubles ✔
public abstract class EntityControllerTests<TEntity> where TEntity : EntityBase
{

protected abstract Mock<IEntityService<TEntity>> CreateService();

This comment has been minimized.

Copy link
@Cooperwutzke

Cooperwutzke Feb 6, 2020

Mocking framework used to create the test doubles ✔

.AddScoped<IGiftService, GiftService>()
.AddScoped<IGroupService, GroupService>();

services.AddAutoMapper(typeof(AutomapperConfigurationProfile).Assembly)

This comment has been minimized.

Copy link
@Cooperwutzke

Cooperwutzke Feb 6, 2020

AutoMapper properly registered ✔


For this assignment you will be setting up the SecretSanta.Api project.
[![Build Status](https://dev.azure.com/GamerBah/EWU-CSCD379-2020-Winter/_apis/build/status/GamerBah.EWU-CSCD379-2020-Winter?branchName=Assignment4)](https://dev.azure.com/GamerBah/EWU-CSCD379-2020-Winter/_build/latest?definitionId=3&branchName=Assignment4)

This comment has been minimized.

Copy link
@Cooperwutzke

Cooperwutzke Feb 6, 2020

The link does take you to a run of Assignment4 which is good! I'm not sure exactly what's wrong with your badge! Your Dev Ops environment is missing some options compared to mine. Sorry buddy maybe one of the profs can help you!

Copy link
Collaborator

Keboo left a comment

(GamerBah)

Assignment4

Project Analysis Summary
Nullable Enabled:
Unexpected Disabled Warnings:
Appropriately handle all warnings:
ProjectName Nullable Solutions Analyzers Unexpected Disabled Warnings Waning Level
SecretSanta.Api Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp.Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.EntityFrameworkCore.Analyzers 4
SecretSanta.Business Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.EntityFrameworkCore.Analyzers 4
SecretSanta.Data Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.EntityFrameworkCore.Analyzers 4
SecretSanta.Web Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer 4
SecretSanta.Api.Tests Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp.Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.EntityFrameworkCore.Analyzers 4
SecretSanta.Business.Tests Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.EntityFrameworkCore.Analyzers 4
SecretSanta.Data.Tests Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.EntityFrameworkCore.Analyzers 4
SecretSanta.Web.Tests Enable SecretSanta.sln IntelliTect Analyzers, Microsoft CodeQuality Analyzers, Microsoft .NET Core Analyzers, Microsoft .NET Framework Analyzers, Microsoft.CodeAnalysis.VersionCheckAnalyzer 4

Main Assignment

  • WebAPI Analyzers enabled ✔
  • DI properly configured ✔
  • Services properly registered with correct scopes ✔
  • DB context properly registered ✔
  • AutoMapper properly registered ✔
  • NSwag properly setup ✔
  • API controllers properly expose CRUD operations ✔
  • Controllers are all unit tested ✔

Extra Credit

  • Unit tests in EntityServiceTests fixed appropriately
  • Mocking framework used to create the test doubles ✔

Peer Review

  • On time ✔
  • Accurate ✔
  • Appropriate comments given ✔

// Delete Entity
service.Setup(s => s.DeleteAsync(1)).ReturnsAsync(true);
var removed = await controller.Delete(1);

This comment has been minimized.

Copy link
@Keboo

Keboo Feb 10, 2020

Collaborator

Local variable 'removed' is unused

@Keboo Keboo closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.