From f5260706077ad2f7e718d4ca184c4269e9d6c8a4 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 27 Mar 2019 15:10:41 -0700 Subject: [PATCH 1/3] Deprecating IntelliWait in favor of Polly --- IntelliTect.IntelliWait/Poll.cs | 1 + IntelliTect.IntelliWait/Wait.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/IntelliTect.IntelliWait/Poll.cs b/IntelliTect.IntelliWait/Poll.cs index aa8fe1b..b92ec38 100644 --- a/IntelliTect.IntelliWait/Poll.cs +++ b/IntelliTect.IntelliWait/Poll.cs @@ -6,6 +6,7 @@ namespace IntelliTect.IntelliWait { + [Obsolete("Deprecating in favor of Polly, which is a more robust and flexible polling library: https://github.com/App-vNext/Polly")] public static class Poll { /// diff --git a/IntelliTect.IntelliWait/Wait.cs b/IntelliTect.IntelliWait/Wait.cs index 47d3c06..d369bf6 100644 --- a/IntelliTect.IntelliWait/Wait.cs +++ b/IntelliTect.IntelliWait/Wait.cs @@ -6,7 +6,7 @@ namespace IntelliTect.IntelliWait { - [Obsolete("Deprecating Wait.Until() naming convention in favor of more accurate and descriptive Poll.UntilNoExceptions naming")] + [Obsolete("Deprecating in favor of Polly, which is a more robust and flexible polling library: https://github.com/App-vNext/Polly")] public static class Wait { /// From 34c8dc854f9596b741d86e56f52f71c71985f902 Mon Sep 17 00:00:00 2001 From: Mike Curn Date: Mon, 15 Jul 2019 19:19:32 -0700 Subject: [PATCH 2/3] Updating csproj for correct semver --- IntelliTect.IntelliWait/IntelliTect.IntelliWait.csproj | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/IntelliTect.IntelliWait/IntelliTect.IntelliWait.csproj b/IntelliTect.IntelliWait/IntelliTect.IntelliWait.csproj index 479d0ff..0d7a017 100644 --- a/IntelliTect.IntelliWait/IntelliTect.IntelliWait.csproj +++ b/IntelliTect.IntelliWait/IntelliTect.IntelliWait.csproj @@ -6,15 +6,16 @@ IntelliTect-Nuget; Mike Curn IntelliTect Set of methods to facilitate waiting a certain amount of time for a delegate to evaluate, while ignoring certain exceptions while attempting to evaluate, and throwing after a specified time limit (or throwing immediately if an unexpected exception is encountered) - https://github.com/IntelliTect/IntelliTect/blob/master/LICENSE + Copyright © IntelliTect 2018 https://github.com/IntelliTect/IntelliTect https://github.com/IntelliTect/IntelliTect Git ui test, automated test, testing, api test, web test, integration test, await, async - Function rename to get away from Selenium terminology, and to use a more generic (but accurate) name for what the functions do (new terminology: Poll.UntilNoExceptions) -Obsoleting old Wait.Until terminology + Obsoleting in favor of Polly IntelliTect.IntelliWait + 1.2.0 + MIT From f73c3654cf9c51db707e08fa2469f034df9763c7 Mon Sep 17 00:00:00 2001 From: Mike Curn Date: Tue, 16 Jul 2019 17:53:06 -0700 Subject: [PATCH 3/3] Removing problematic test since we're deprecating anyway --- .../UnExpectedExceptionsTests.cs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/IntelliTect.IntelliWait.Tests/UnExpectedExceptionsTests.cs b/IntelliTect.IntelliWait.Tests/UnExpectedExceptionsTests.cs index 78ef348..7a1cfc5 100644 --- a/IntelliTect.IntelliWait.Tests/UnExpectedExceptionsTests.cs +++ b/IntelliTect.IntelliWait.Tests/UnExpectedExceptionsTests.cs @@ -78,14 +78,6 @@ await Assert.ThrowsAsync( () => Test.CheckExceptionsVoidReturn(1, 3), TimeSpan.FromSeconds(2))); } - [Fact] - public async Task CheckFuncGenericForThreeUnExpectedExpectionsThrows() - { - await Assert.ThrowsAsync( - () => Poll.UntilNoExceptions( - () => Test.CheckExceptionsBoolReturn(1, 3), TimeSpan.FromSeconds(2))); - } - [Fact] public async Task CheckActionGenericForFourUnExpectedExpectionsThrows() {