Checking in windows desktop automated test wrapper and example projects

[PandaMagnus]

No description provided.

[Keboo]

Some comments, let me know if you have any questions on things.

[Keboo]

Set protection modifier.

[Keboo]

If it is possible for FindResultsControl() to return null, add null propagation operator before .Name

[Keboo]

Add protection modifiers

[Keboo]

A better way to do this is

using System.IO;
...
string formattedPath = Path.Combine(location, filename);

Typically you want to avoid specifying the folder separator (and use Path.DirectorySeparator where you have to use it)

[Keboo]

This will functionally change everything after the file extension. Is this intentional?
Is something like this what you were hoping to achieve?

public static string GetUniqueFileName(string filePath)
{
    string uniqueFileName = filePath;
    for (int i = 0; File.Exists(uniqueFileName); uniqueFileName = AppendFileName(filePath, $" ({++i})"))
    { }
    return uniqueFileName;
}

public static string AppendFileName(string filePath, string toAppend)
{
    var dir = Path.GetDirectoryName(filePath);
    var fileName = Path.GetFileNameWithoutExtension(filePath);
    var extension = Path.GetExtension(filePath);
    return Path.Combine(dir ?? "", string.Concat(fileName, toAppend, extension));
}

[PandaMagnus]

It was not intentional. It was an oversight on me trying to come up with something quick and not double checking. However, your comment has got me thinking that there is a better way in general to handling saving files for a test. I will do some poking around with this...

[Keboo]

When you only have one pieces of text you can simplify this to be:

<TextBlock Text="{Binding Path=MyListItem}" />

[Keboo]

There is a bunch of code duplication between these two cases. I think you want something like this:

protected UITestControl BuildControlHeirarchy(SearchTypes searchType, string baseControl, params string[] controlList)        
{ 
    if (searchType == null) 
        throw new ArgumentNullException(nameof(searchType)); 
    if (baseControl == null) 
        throw new ArgumentNullException(nameof(baseControl)); 
    UITestControl foundControl; 
    switch(searchType)
    {
        case SearchTypes.AutomationId:
            foundControl = FindControlImpl((controlName, rootControl) => FindWpfControlByAutomationId(controlName, c => new WpfControl(c), rootControl)); 
        case SearchTypes.ControlName:
            foundControl = FindControlImpl((controlName, rootControl) => FindControlByName(controlName, c => new UITestControl(c), rootControl));
        default:
            foundControl = new UITestControl();
    }
    return foundControl; 
}

private UITestControl FindControlImpl(Func<string, UITestControl, UITestControl> findMethod, string baseControl, string[] childControls)
{
    UITestControl foundControl = findMethod(baseControl, FindWinWindowUnderTest()); 
    if ( childControls?.Any() == true) 
    { 
        foreach (string control in controlList) 
        { 
            foundControl = findMethod(control, foundControl);
        } 
    } 
    return foundControl;
}

Few things to note:

• foundControl starts as null and we only give it the default value in the unlikely case where we have not set it to anything else
• Use a switch rather than a bunch of if statements when acting on an enum.
• The common logic is abstracted into its own method
• Added null propogation operator when checking childControls. Typically you don't need to check values that come from params as the compiler will put in an empty array unless the caller specifically passes null.
• Zero testing of this code on my part, so there may be errors.

[Keboo]

This is a common pattern to keep from accidently duplicating event handlers. I suspect that was likely the cause.

[Keboo]

You probably want to name this something like retryAttempts since it is not actually a measurement of seconds.

[Keboo]

Use Path.Combine here and you won't need to worry about if the location ends with a slash or not.

[Keboo]