Skip to content

Conversation

@zyxkad
Copy link
Collaborator

@zyxkad zyxkad commented Dec 18, 2024

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • The commit message are well described
  • Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Calculate distance method is not run on the main thread which cause possible thread sync issue

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)

  • Other information:

@SirEndii
Copy link
Member

Checkstyle seems to have some warnings
Not sure if they came from our other PR
But could you fix them?

@zyxkad zyxkad requested a review from SirEndii December 19, 2024 00:58
@zyxkad zyxkad merged commit 1359c97 into IntelligenceModding:dev/0.8 Dec 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants