ci: Add GPU builds #193
ci: Add GPU builds #193
Conversation
.circleci/config.yml
Outdated
| openmpi-bin \ | ||
| ssh | ||
|
|
||
| cmake -S . -B /tmp/build -DENABLE_DIST_GALOIS=ON -DENABLE_HETERO_GALOIS=ON |
There was a problem hiding this comment.
-> cmake -S . -B /tmp/build -DGALOIS_ENABLE_DIST=ON -DGALOIS_ENABLE_GPU=ON
.circleci/config.yml
Outdated
| openmpi-bin \ | ||
| ssh | ||
|
|
||
| cmake -S . -B /tmp/build -DENABLE_DIST_GALOIS=ON -DENABLE_HETERO_GALOIS=ON |
There was a problem hiding this comment.
-> cmake -S . -B /tmp/build -DGALOIS_ENABLE_DIST=ON -DGALOIS_ENABLE_GPU=ON
There was a problem hiding this comment.
Thanks for reminding me! Though this change only needed if this PR goes in after #199 . Otherwise it is actually correct as it stands.
| @@ -1,6 +1,3 @@ | |||
| [submodule "bliss"] | |||
There was a problem hiding this comment.
Why is this removed? I thought this was required for pangolin.
There was a problem hiding this comment.
It is already vendored in external directly rather than as a submodule. The submodule itself was just something @chenxuhao made to track bliss upstream but it seems simpler to avoid inserting an intermediary.
There was a problem hiding this comment.
Yes, it's better it's not a submodule but that is not related to this PR. As long as pangolin builds don't break, it's fine to be included in this PR.
There was a problem hiding this comment.
FWIW, the reason the commit is here is because we have to enable submodules for GPU builds, so I took the opportunity to clean up our submodule configuration, which has these unused entries.
|
LGTM |
Now that we do not have the broken LCI submodule, we can checkout submodules without error.
| @@ -2,11 +2,8 @@ dist: bionic | |||
|
|
|||
| language: c++ | |||
|
|
|||
| # At the moment, our LCI submodule has an additional submodule within it | |||
There was a problem hiding this comment.
Good catch. This comment is outdated now that the LCI submodule is gone.
You are correct, but I figured it would be easier for maintenance and reduce the number of moving parts if we just standardized what it means to check out the repo (checked out or not vs checked out with submodules, checked out without ....). Alternatively, I imagine my future self to be a little surprised to see CI fail if I added a submodule that the CPU code needed, and my future self would have to add this same submodule checkout code anyway. |
The CI won't pass until at least these issues are resolved:
(just for historical context, I noticed these errors while discussing #92 though they are not related to that issue itself)
Closes #190