New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup not keyboard accessible #45

Closed
ChrisBAshton opened this Issue Jun 21, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@ChrisBAshton

ChrisBAshton commented Jun 21, 2018

Hello - apologies if I'm raising this in the wrong place and I've got the wrong people!

I've seen this kind of popup in a few places recently:

screen shot 2018-06-21 at 20 48 01

I noticed that the buttons - 'Update Privacy Settings', 'Sounds Good, Thanks' and 'Not Now' are not keyboard accessible (there is no way of tabbing to them). I think we're just missing a href attribute:

<a class="fp5lCfuR-1- _2psJxRh1-1- amwo9KVF-1-" automate_uuid="839647d1-16d6-4ccb-ba31-7fba5301a328"><span class="_1MrLfucw-1-">Update Privacy Settings</span></a>

Whilst we're here, looks like these buttons have nice :hover styles applied to them, can you apply the same thing to :focus so that it's clear what's in focus when the buttons are tabbed to via keyboard?

Finally, worth applying a tabindex="1" on the first button to make sure users can navigate to it right away.

If I have raised this in the wrong place, could you please point me in the right direction? I stumbled onto this repo via this IABEurope blog post, and IABEurope via this Global Vendors registration page, and consensu.org via the Network tab of the pages I've been on recently!

Thanks.

@HeinzBaumann

This comment has been minimized.

HeinzBaumann commented Jun 21, 2018

You are at the right place. This is a sample. Please feel free to create a pull request with the required changes. :)

@ChrisBAshton

This comment has been minimized.

ChrisBAshton commented Jun 22, 2018

Hi - I would happily make a PR but I couldn't find the code in this repo 🤔the code looks extremely similar to what's on https://www.itworld.com/ and https://www.pcworld.com/ but their popup seems to be using <a> anchor links, and I can only see references to Button in this repo.

Are you saying that sites will implement their own versions of cookie management, taking inspiration from this repo rather than using code from this repo directly? In which case, perhaps I am in the wrong place and should be getting in touch with ITWorld/PCWorld directly...?

EDIT: tracked down the itworld.com script to https://spiffymachine.com/v2/0/xal73nFqanfakVhzUbAKANfcx0ZlfrIN7PwH4ZOFlRXI2WjDrcC79t7FKrEcD3NjGkwLPorqsgVTsZlQfyl.

@Brikky

This comment has been minimized.

Contributor

Brikky commented Jun 22, 2018

@ChrisBAshton There is a reference implementation in this repo, but different companies/sites also develop their own approaches within the spec. You might want to bring it to the attention of those websites, and they can communicate it with whoever is developing/maintaining their CMP.

@ChrisBAshton

This comment has been minimized.

ChrisBAshton commented Jun 23, 2018

Thanks @Brikky, that's actually very useful - it's hard to reverse engineer how this is all set up globally!

I've found a list of affected websites and they're all owned by IDG - I'm not sure if the implementation is exclusive to IDG-owned sites or if they're using something that is more widespread, but I have now reached out to them via email.

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment