Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npc presence when rest dialog dismissed #1466

Merged
merged 2 commits into from Aug 28, 2019
Merged

Update npc presence when rest dialog dismissed #1466

merged 2 commits into from Aug 28, 2019

Conversation

ajrb
Copy link
Collaborator

@ajrb ajrb commented Aug 26, 2019

I get annoyed when resting in a guild for npcs to arrive and have to exit and reenter the building for them to show up. Added a check when rest dialog is dismissed.

@petchema
Copy link
Collaborator

petchema commented Aug 26, 2019

Will they also be able to disappear as you sleep?
It's certainly more logic, but some people may whine (say, rest in fighters guild to (ab)use trainer every 12 hours...)

@ajrb
Copy link
Collaborator Author

ajrb commented Aug 26, 2019

You think it should only work to make NPCs appear? Yeah, I think I agree actually, since I've done that myself. So PR updated!

@bansheexyz
Copy link
Contributor

I like the idea of NPCs appearing and disappearing on schedule regardless of player presence. It doesn't make sense that they would just stay awake forever waiting on you.

Also, I feel like the player should get kicked out when there's closure. You can stay in a place that closes indefinitely so long as you entered when it was open? Why? Feels nonsensical and ruins the 24/7 perk.

@ajrb
Copy link
Collaborator Author

ajrb commented Aug 27, 2019

When I originally implemented NPC schedules and closed the classic loophole allowing save/load to have the shopkeep vanish for easy stealing, the possibility of ejection was discussed and discarded for core DFU.

@Interkarma
Copy link
Owner

Love it, thank you! :)

@Interkarma Interkarma merged commit c869ea9 into Interkarma:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants