Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest item dropping fixes #1487

Merged
merged 1 commit into from Sep 5, 2019

Conversation

@JorisVanEijden
Copy link
Contributor

commented Sep 5, 2019

  • Picking up previously dropped quest items would not unset the dropped state because they come from Loot, not Dropped.
  • Moving quest Items to Loot piles or Merchants would not set the dropped state.
  • Picking up quest items without AllowDrop would not unset the dropped state.
  • Bitwise or in stead of logical or could cause null reference.

Test quest:

- Test quest for dropping and picking up quest items
Quest: __TEST001
QRC:
QBN:
Place _house_ local house2
Item _treasure_ portrait

	place item _treasure_ at _house_

_pickedup_ task:
	clicked item _treasure_
	clear _dropped_

_dropped_ task:
	dropped _treasure_ at _house_
	clear _pickedup_
…ed state because they come from Loot, not Dropped.

- Moving quest Items to Loot piles or Merchants would not set the dropped state.
- Picking up quest items without AllowDrop would not unset the dropped state.
@Interkarma

This comment has been minimized.

Copy link
Owner

commented Sep 5, 2019

Yeah, that logical or typo is embarrassing. Thanks for the fixes Joris! :)

@Interkarma Interkarma merged commit d08b5ab into Interkarma:master Sep 5, 2019
@JorisVanEijden JorisVanEijden deleted the stellargames:quest_item_dropping_fix branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.