Added a "generator" customization point for PopulationManager #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can hook PopulationManager.MobileNPCGenerator to change the properties of NPCs (race, gender, name, outfit, face) before they're enabled.
Interkarma
reviewed
Oct 11, 2022
| @@ -279,6 +288,7 @@ int CreateNewPoolItem() | |||
| PoolItem poolItem = new PoolItem(); | |||
| poolItem.npc = npc; | |||
| poolItem.npc.Motor = motor; | |||
| poolItem.npc.Asset = motor.MobileAsset; | |||
There was a problem hiding this comment.
Good idea. This is a better place to set Asset rather than use GetComponentInChildren. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our mod plans is to expand the selection of mobile NPCs generated in towns.
Currently, the PopulationManager chooses the race of the mobile using the climate settings, then passes it on to
MobilePersonNPC.RandomiseNPCwhich takes care of the rest. Other NPC settings like gender, outfit, face, guard, and name are determined internally.We've previously worked around some of these limitations with
PopulationManager.OnMobileNPCEnable, but all we can really do is callRandomiseNPCa second time with another race (we've put Redguards in Swamp and Subtropical climates, for example). This approach only works for Bretons, Redguards, and Nords, since other races aren't supported.In addition to the limitations of this approach, this also had the issue of causing two calls to
MobilePersonAsset.SetPerson, which cause two sets of textures to be loaded per NPC.This PR thus does two things:
MobilePersonNPCproperties from the outsidePopulationManagera hook for mods to do their own thing instead of calling.RandomiseNPC(avoids the double call toMobilePersonAsset.SetPersonproblem)With this, we can generate NPCs of any race, with any outfit and face we want. Custom portrait records are already supported by
DaggerfallTalkWindow.SetNPCPortrait.Results (ignore sprite scale lol):
