GITFNS prc fails if pull request branch name contains parenthesis

[MattHeffron]

Describe the bug
The prc command of GITFNS fails with a "Command failed: ..." error if any pull request branch name includes parens. For example, rmk19--Shorter-directory-names-in-COMPAREDIRECTORIES-printout-(costmetic) .

To Reproduce
Steps to reproduce the behavior:

1. Files loaded GITFNS.LCOM
2. Type prc to Exec window.
3. INTERLISP-ERROR Break window opens with
   

Expected behavior
Display of menu of open PRs.

Context (please complete the following information):

• OS: Windows 11, WSL, Ubuntu
• OS Version: Ubuntu 22
• Host arch: x86_64
• Maiko version: [e.g. commit ID from git log | head]
• IL:MAKESYSDATE: 30-Apr-2024

Additional context
See PR #1692 for potential fix (but may conflict with PR #1689)

[rmkaplan]

I saw this when I first tried to create it with the GITFNS cob command. I made a branch without the parens, but I couldn’t figure out how to find the bad one to delete it. Is this an issue in github, that it can’t have parens in these title strings? Or do the parens have to be escaped ior quoted n the command string that GITFNS passes down. Is this related to the JSON return value, or a separate issue?

…

On May 2, 2024, at 12:12 AM, Matt Heffron ***@***.***> wrote: Describe the bug The prc command of GITFNS fails with a "Command failed: ..." error if any pull request branch name includes parens. For example, rmk19--Shorter-directory-names-in-COMPAREDIRECTORIES-printout-(costmetic) . To Reproduce Steps to reproduce the behavior: Files loaded GITFNS.LCOM Type prc to Exec window. INTERLISP-ERROR Break window opens with image.png (view on web) <https://github.com/Interlisp/medley/assets/8261874/9fbdceab-c756-4ac8-96f2-75eaa471232a> Expected behavior Display of menu of open PRs. Context (please complete the following information): OS: Windows 11, WSL, Ubuntu OS Version: Ubuntu 22 Host arch: x86_64 Maiko version: [e.g. commit ID from git log | head] IL:MAKESYSDATE: 30-Apr-2024 Additional context Add any other context about the problem here. — Reply to this email directly, view it on GitHub <#1691>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJOJ7VBCHWT5DKTGRZDZAHRMLAVCNFSM6AAAAABHDE43O6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TINZYGY4DSNQ>. You are receiving this because you are subscribed to this thread.

[MattHeffron]

The problem is the shell command line parsing. It doesn't like the unquoted parens. I verified this by entering the identical command to the shell and it gave a shell error. Just quoting the branch name in the command fixes this.
I've cancelled PR #1692, and I will create a new PR in a new branch based on PR #1689.