Skip to content

Modify launcher to enable --title STRING option to work when STRING has embedded spaces (multiple words). #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattHeffron merged 1 commit into from
Oct 18, 2023
Merged

Modify launcher to enable --title STRING option to work when STRING has embedded spaces (multiple words). #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion run-medley
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ while [ "$#" -ne 0 ]; do
shift
;;
-title)
title="$2"
if [ -n "$2" ] ; then
title="$2"
fi
shift
;;
-vmem | --vmem | -vmfile)
Expand Down
2 changes: 1 addition & 1 deletion scripts/medley/medley.command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ mkdir -p ${LOGINDIR}/vmem
if [[ ( ${darwin} = true ) || (( ${wsl} = false || ${use_vnc} = false ) && ${docker} = false) ]];
then
# If not using vnc, just call run-medley
${MEDLEYDIR}/run-medley -id "${run_id}" ${geometry} ${screensize} ${run_args[@]}
${MEDLEYDIR}/run-medley -id "${run_id}" -title "${title}" ${geometry} ${screensize} ${run_args[@]}
else
# do the vnc thing on wsl or docker
source ${SCRIPTDIR}/medley_vnc.sh
Expand Down
4 changes: 3 additions & 1 deletion scripts/medley/medley_args.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ run_id="default"
screensize=""
sysout_flag=false
sysout_arg=""
title=""
use_vnc=false
windows=false

Expand Down Expand Up @@ -112,7 +113,8 @@ do
;;
-t | --title)
check_for_dash_or_end "$1" "$2"
run_args+=(-title $2)
#run_args+=(-title $2)
title="$2"
shift
;;
-v | --vnc)
Expand Down