Skip to content

Conversation

@masinter
Copy link
Member

  • Change numeric OPCODES SUBRCALL NN to use the LLSUBRS name
  • more opcodes subr# in maikoloadupfns
  • even more OPCODES SUBRCALL

@masinter masinter changed the title Replace (OPCODES SBURCALL subrbumber) with (SBURCALL SUBRNAME ... Replace (OPCODES SUBRCALL subrnumber) with (SUBRCALL subrname Oct 26, 2021
@masinter
Copy link
Member Author

a do-over of PR #543 the problem was there are functions in LLCOLOR that are over-written by the newer library/BIGBITMAPS (which is more about color than bigger dimensions for bitmaps). Maybe with SDL?

@masinter masinter requested a review from nbriggs October 26, 2021 23:34
@masinter masinter requested review from nbriggs and rmkaplan October 27, 2021 03:27
Copy link
Contributor

@rmkaplan rmkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this one to Nick.

@rmkaplan
Copy link
Contributor

rmkaplan commented Oct 27, 2021 via email

@nbriggs
Copy link
Contributor

nbriggs commented Oct 27, 2021

Also COMMENTCOLUMN as used by SUPERPRINT/COMMENT1 as defined in NEWPRINTDEF. I think it's trying to leave them on one line, but the length of a typical editdate may have changed, so it's breaking it.

Copy link
Contributor

@nbriggs nbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By inspection (I can't test it) I think this is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants