-
-
Notifications
You must be signed in to change notification settings - Fork 29
Replace (OPCODES SUBRCALL subrnumber) with (SUBRCALL subrname #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
masinter
commented
Oct 26, 2021
- Change numeric OPCODES SUBRCALL NN to use the LLSUBRS name
- more opcodes subr# in maikoloadupfns
- even more OPCODES SUBRCALL
|
a do-over of PR #543 the problem was there are functions in LLCOLOR that are over-written by the newer library/BIGBITMAPS (which is more about color than bigger dimensions for bitmaps). Maybe with SDL? |
rmkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this one to Nick.
|
There’s a variable COMMENTLINELENGTH = (116 . 126), maybe that has something to do with it
… On Oct 27, 2021, at 1:13 PM, Nick Briggs ***@***.***> wrote:
@nbriggs commented on this pull request.
In library/MAIKOCOLOR <#553 (comment)>:
> (replace (DISPLAYSTATE ONOFF) of DISPLAYSTATE with 'ON])
(\MAIKO.STOPCOLOR
- [LAMBDA (FDEV) (* ; "Edited 28-Apr-89 16:51 by tshimizu.fx")
+ [LAMBDA (FDEV) (* ;
Do you know what controls the comment starting column and the maximum line length, and can they be adjusted slightly such that it doesn't end up splitting these comments over two lines instead of keeping them on one?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#553 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJOWB2NZ6LFOGCC3PTTUJBMNRANCNFSM5GYQ5GEQ>.
|
|
Also COMMENTCOLUMN as used by SUPERPRINT/COMMENT1 as defined in NEWPRINTDEF. I think it's trying to leave them on one line, but the length of a typical editdate may have changed, so it's breaking it. |
nbriggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By inspection (I can't test it) I think this is OK.