fixed the deprecated keywords in the neo4j queries

[ronibhakta1]

@m-appel check this out i have made the asked changes...
closes #154

Description

id() changed with elementId() in neo4j with new required documentation elementId()

Motivation and Context

How Has This Been Tested?

pre-commit checks

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[m-appel]

This line is broken now and causes a syntax error.

[m-appel]

Hi, I'm not sure what kind of code formatter you use, but please don't introduce unnecessary formatting changes as it crowds the PR. Our line length (specified in .flake8) is 120 characters.
The formatter also broke one line, which is why the pre-commit checks are failing.

So please only change the requested fields and test the functions. The testing part is the reason this is an issue and not just a simple Search + Replace, since it requires running a neo4j instance and confirming that the functions still behave the same.

[ronibhakta1]

Hi, I'm not sure what kind of code formatter you use, but please don't introduce unnecessary formatting changes as it crowds the PR. Our line length (specified in .flake8) is 120 characters.
The formatter also broke one line, which is why the pre-commit checks are failing.

So please only change the requested fields and test the functions. The testing part is the reason this is an issue and not just a simple Search + Replace, since it requires running a neo4j instance and confirming that the functions still behave the same.

I will take a look at it, I'm trying to understand the whole product itself.

[ronibhakta1]

Hi, I'm not sure what kind of code formatter you use, but please don't introduce unnecessary formatting changes as it crowds the PR. Our line length (specified in .flake8) is 120 characters. The formatter also broke one line, which is why the pre-commit checks are failing.

So please only change the requested fields and test the functions. The testing part is the reason this is an issue and not just a simple Search + Replace, since it requires running a neo4j instance and confirming that the functions still behave the same.

i have done the fix in the files. can you help me with running a neo4j instance and confirming that the functions still behave the same.

[m-appel]

Hey, since this has become somewhat urgent, I am testing this myself.
In general, to get a database up and running, you should look at the main README.
To test the behavior, I am just running versions of the old and new queries against the webinterface and see if they behave the same.

[ronibhakta1]

,

Hey thanks a lot, I'm new to open source and contributing to many organisations. And due to different projects it's taking time to understand their projects. I have checked the issue I was facing on my end was due to vs code idk why it was making a mess on my Mac. Anyways thanks again I will get things done next time :)

[m-appel]

No worries, I still welcome you to try and getting IYP up and running and try it out.
I would have given you more time, but we just updated our neo4j version and are now getting spammed with "id() is deprecated" messages, so I want to merge this asap :)

[ronibhakta1]

I hope that I have made the changes as soon as possible, some IDE problems but hope I made it in your comfortable time 😄

…

On Fri, 6 Dec, 2024, 11:46 am mtashiro, ***@***.***> wrote: No worries, I still welcome you to try and getting IYP up and running and try it out. I would have given you more time, but we just updated our neo4j version and are now getting spammed with "id() is deprecated" messages, so I want to merge this asap :) — Reply to this email directly, view it on GitHub <#159 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASOW2LAFFWQKNELZHK2I7BD2EE6M7AVCNFSM6AAAAABS7DHXH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRSGIZDQOBVGU> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>