Repository navigation
fix nix impurity - #4518
Merged
Merged
fix nix impurity#4518
Conversation
disassembler
approved these changes
Nov 9, 2022
Jimbo4350
self-requested a review
November 9, 2022 18:27
Jimbo4350
requested changes
Nov 9, 2022
Jimbo4350
left a comment
Jimbo4350
left a comment
Contributor
There was a problem hiding this comment.
@dermetfan can you update the commit message beyond "fix impurity"? Please include something that indicates this commit only touches the nix derivations.
Contributor
Author
|
@Jimbo4350 Better now? |
Jimbo4350
approved these changes
Nov 9, 2022
There was access to impure builtins in the nix evaluation so pure evaluation was not possible.
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builtins.currentSystemis not available in pure evaluation.Discovered while working on IntersectMBO/cardano-db-sync#1280.