fix wait-for-hydra for when there are too many check runs - #6127
Merged
Conversation
dermetfan
force-pushed
the
fix-gha-wait-for-hydra
branch
2 times, most recently
from
February 20, 2025 21:28
b4abef8 to
195e592
Compare
johnalotoski
approved these changes
Feb 20, 2025
neilmayhew
approved these changes
Feb 20, 2025
neilmayhew
left a comment
Contributor
There was a problem hiding this comment.
LGTM, although I think it would be good to expand the cases for "$conclusion" as well, so that the default case produces an error.
dermetfan
commented
Feb 20, 2025
dermetfan
force-pushed
the
fix-gha-wait-for-hydra
branch
from
February 20, 2025 23:02
10cfb11 to
854ed96
Compare
neilmayhew
reviewed
Feb 20, 2025
neilmayhew
approved these changes
Feb 21, 2025
neilmayhew
left a comment
Contributor
There was a problem hiding this comment.
Great to have this fixed
neilmayhew
enabled auto-merge
February 21, 2025 13:59
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Feb 21, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When there are more than 30 (the default pagination page size) check runs, the Hydra statuses are sometimes not found, blocking progress.
We can query only the status we need instead of searching though all statuses.
Also includes #6126, as requested, so we only have to merge one PR.
Checklist
New tests are added if needed and existing tests are updated.Any changes are noted in theCHANGELOG.mdfor affected packageThe version bounds in.cabalfiles are updatedCode is linted withhlint. See.github/workflows/check-hlint.ymlto get thehlintversionCode is formatted withstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionCode builds on Linux, MacOS and Windows forghc-8.10.7andghc-9.2.7