From a6c6bc0e329f11372f264ee8daf6c7ec1dbe92ae Mon Sep 17 00:00:00 2001 From: Alexander Esgen Date: Fri, 5 Aug 2022 13:08:11 +0200 Subject: [PATCH] Disable ChainDB q-s-m test on Windows --- .github/PULL_REQUEST_TEMPLATE.md | 2 -- .../test-storage/Test/Ouroboros/Storage/ChainDB.hs | 10 +++++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 143803dce06..49c67fa391f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,8 +6,6 @@ Sadly, some CI checks are currently flaky. Right now, this includes: - GH Actions Windows job runs out of memory, e.g. in https://github.com/input-output-hk/ouroboros-network/runs/7231748864?check_suite_focus=true - - The Hydra check for test-storage on Windows (mingwW64) fails with inscrutable malloc-related error messages: https://hydra.iohk.io/build/16260881/nixlog/1 - - The tests in WallClock.delay* can fail under load (quite rarely): https://hydra.iohk.io/build/16723452/nixlog/76 If you encounter one of these, try restarting the job to see if the failure vanishes. If it does not or when in doubt, consider posting in the #network or #consensus channels on Slack. diff --git a/ouroboros-consensus-test/test-storage/Test/Ouroboros/Storage/ChainDB.hs b/ouroboros-consensus-test/test-storage/Test/Ouroboros/Storage/ChainDB.hs index 1ca557f8c5f..bd8d6296526 100644 --- a/ouroboros-consensus-test/test-storage/Test/Ouroboros/Storage/ChainDB.hs +++ b/ouroboros-consensus-test/test-storage/Test/Ouroboros/Storage/ChainDB.hs @@ -1,5 +1,7 @@ module Test.Ouroboros.Storage.ChainDB (tests) where +import System.Info (os) + import Test.Tasty import qualified Test.Ouroboros.Storage.ChainDB.GcSchedule as GcSchedule @@ -9,10 +11,12 @@ import qualified Test.Ouroboros.Storage.ChainDB.Paths as Paths import qualified Test.Ouroboros.Storage.ChainDB.StateMachine as StateMachine tests :: TestTree -tests = testGroup "ChainDB" [ +tests = testGroup "ChainDB" $ [ Iterator.tests , GcSchedule.tests , Model.tests , Paths.tests - , StateMachine.tests - ] + ] <> + -- The ChainDB q-s-m test is flaky on Windows, see + -- https://github.com/input-output-hk/ouroboros-network/issues/3874 + [ StateMachine.tests | os /= "mingw32" ]