Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add getThumbnail method #9

Merged
merged 3 commits into from Apr 2, 2022
Merged

feat: add getThumbnail method #9

merged 3 commits into from Apr 2, 2022

Conversation

Danielwinkelmann
Copy link
Contributor

@Danielwinkelmann Danielwinkelmann commented Apr 1, 2022 •
edited

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

add getThumbnail method, to generate image url with given options from the Directus file API

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@netlify
Copy link

netlify bot commented Apr 1, 2022 •
edited

✅ Deploy Preview for nuxt-directus canceled.

Name Link
🔨 Latest commit 4707cab
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-directus/deploys/6247e3f7225ace000885532c

@Intevel
Copy link
Owner

Intevel commented Apr 1, 2022

Hey, thanks for your PR @Danielwinkelmann. ❤️

Can you update the playground to test it?

@Danielwinkelmann
Copy link
Contributor Author

Hey @Intevel, I upload an image to the Directus Sample CMS and add the file-id to the playground.
You have to enable public file access for the public Role to get it working.

@Intevel Intevel added the enhancement New feature or request label Apr 2, 2022
Intevel
Intevel approved these changes Apr 2, 2022
View reviewed changes
Copy link
Owner

@Intevel Intevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good job.
Test with playground was successful 💯

@Intevel Intevel added the waiting for merge Approved, is waiting for merge. label Apr 2, 2022
@Danielwinkelmann
Copy link
Contributor Author

Thanks :-)
add another PR to add some typescript support

@Intevel Intevel merged commit 5f79e08 into Intevel:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intevel Intevel Intevel approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request waiting for merge Approved, is waiting for merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Danielwinkelmann @Intevel