Updated IntrepidSwiftWisdomTesting for Swift 3. #111
Conversation
IntrepidSwiftWisdomTesting.podspec
Outdated
| @@ -1,17 +1,17 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = "IntrepidSwiftWisdomTesting" | |||
| s.version = "0.0.7" | |||
| s.version = "0.7.3" | |||
There was a problem hiding this comment.
It was a conscious decision to keep this in lockstep with the Intrepid.podspec version. Please let me know if it's better for this to have its own separate version.
nservidio
force-pushed
the
nservidio/update-IntrepidSwiftWisdomTesting-swift-3
branch
from
e1281f1
to
619b039
Compare
|
I would just run it through a test project if you haven't already done so, but it looks good, thanks for taking this on! |
IntrepidSwiftWisdom.podspec
Outdated
| @@ -17,6 +17,6 @@ Pod::Spec.new do |s| | |||
|
|
|||
| s.subspec "Core" do |cs| | |||
| cs.source_files = "SwiftWisdom/Core/**/**/*.swift" | |||
| cs.dependency 'IP-UIKit-Wisdom', '0.0.9' | |||
| cs.dependency 'IP-UIKit-Wisdom', '0.0.10' | |||
There was a problem hiding this comment.
Actually, @brightredchilli, if we bump this, we should also bump the IntrepidSwiftWisdom.podspec version, theoretically to 0.7.3...? Since we are no longer really maintaining IntrepidSwiftWisdom, should I just revert this?
There was a problem hiding this comment.
no harm to bump both if you're updating. however, none of the changes will be visible until we make a push with the proper tags.
|
This pod predates the unified |
nservidio
force-pushed
the
nservidio/update-IntrepidSwiftWisdomTesting-swift-3
branch
from
619b039
to
80af645
Compare
SwiftWisdomTests/XCTestTests.swift
Outdated
| // Copyright © 2017 Intrepid. All rights reserved. | ||
| // | ||
|
|
||
| //ip_XCTAssertEqualOptional |
There was a problem hiding this comment.
Did you mean to leave these here?
| @@ -1,22 +0,0 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = "IntrepidSwiftWisdom" | |||
There was a problem hiding this comment.
It looks like a few projects use IntrepidSwiftWisdom. Is it ok to remove this spec?
There was a problem hiding this comment.
I think it is safe to remove this podspec because:
- the IntrepidSwiftWisdom spec still exists in the the spec repo
- the old tags still exist on https://github.com/IntrepidPursuits/swift-wisdom that reference IntrepidSwiftWisdom
SwiftWisdomTests/XCTestTests.swift
Outdated
| let value2: Float? = 1.00001 | ||
|
|
||
| ip_XCTAssertEqualWithAccuracyOptional(value1, value2, accuracy: 0.0001) | ||
| } |
There was a problem hiding this comment.
Can you test to make that these assert if you pass erroneous values?
cprime
force-pushed
the
nservidio/update-IntrepidSwiftWisdomTesting-swift-3
branch
from
64a7644
to
5a9f6e2
Compare
cprime
force-pushed
the
nservidio/update-IntrepidSwiftWisdomTesting-swift-3
branch
from
5a9f6e2
to
5d3b564
Compare
I updated the version of IntrepidSwiftWisdomTesting.podspec to 0.7.3 because its source is https://github.com/IntrepidPursuits/swift-wisdom.git.
Updated Readme to refer to swift-wisdom instead of intrepid-wisdom for installing testing additions.
Updated IntrepidSwiftWisdom dependency.