fix(chart): dashboard filters on job, not the unset service=s3proxy#47
Merged
Conversation
Every dashboard panel filtered on `service="s3proxy"`, but the ServiceMonitor-applied `service` label is the release-prefixed Service name (e.g. `service="cockpit-s3proxy"`), so the filter never matched and panels rendered "No data". Switch every panel target and the `instance` variable query to `job=~"$job"`, and add a new `Job` template variable backed by `label_values(http_requests_total, job)` so the picker shows whatever job Prometheus actually emits. Chart bump 1.9.1 -> 1.9.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every dashboard panel filtered on
service="s3proxy", but theServiceMonitor-appliedservicelabel is the release-prefixed Servicename (e.g.
service="cockpit-s3proxy"), so the filter never matched andpanels rendered "No data".
jobcarries the same release-prefixedvalue but is the label Prometheus actually exposes consistently.
This patch:
jobtemplate variable (label_values(http_requests_total, job))between the existing
datasourceandinstancevariables, so thedashboard picks up whatever job string Prometheus emits.
service="s3proxy"withjob=~"$job"in every panel targetand in the
instancevariable'squery.job=~"$job"filter to thes3proxy_*panels (panels 5and 6) so they also scope correctly in multi-release clusters.
Chart bump 1.9.1 → 1.9.2. No values changes.
See
CHANGELOG.md→Chart / 1.9.2.Test plan
jq . charts/s3proxy/dashboards/s3proxy.json >/dev/null— valid JSONhelm lint charts/s3proxy— passeshelm template t charts/s3proxy --set grafanaDashboard.enabled=true --show-only templates/grafana-dashboard.yaml | grep -cF 'job=~\"$job\"'→ 11 (≥ 11)grep -cF 'service=\"s3proxy\"'→ 0 (no stale filter)populate and the
Jobpicker lists e.g.cockpit-s3proxy.chart/dashboard-job-variable.Release flow
Merge → tag
chart-v1.9.2onmain→ CI publishesghcr.io/intrinsec/s3proxy/charts/s3proxy:1.9.2.🤖 Generated with Claude Code