New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP-109: Added suport for having a custom template for each invoice group #334

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Projects
None yet
4 participants
@dantefff
Copy link

dantefff commented Jan 13, 2016

This commit adds a extra select in invoice groups for choosing a custom default template. In case there is no template selected everything works as before.

This allows us having different templates for different kinds of documents (proforma/delivery note/...)

There is a small change in database (see application/modules/setup/sql/017_1.4.4-nextRelease.sql). I didn't know where to put this change so rename this file as you like.

PD: This is a reborn of pull request #333

Added suport for having a custom template for each invoice group
Conflicts:
	application/helpers/pdf_helper.php

Kovah added a commit that referenced this pull request Jan 13, 2016

Merge pull request #334 from dantefff/development
IP-109: Added suport for having a custom template for each invoice group

@Kovah Kovah merged commit aac4605 into InvoicePlane:development Jan 13, 2016

@kintaro1981

This comment has been minimized.

Copy link

kintaro1981 commented Dec 19, 2017

This needs some little cosmetic fixes but it's working on 1.5.5
Another thing: the template selected must be prefilled on the "Send mail" form too.
Plus: the same thing needs to be done for the templates of the web invoices too.

@kintaro1981

This comment has been minimized.

Copy link

kintaro1981 commented Dec 19, 2017

I just saw that it use the "template name" instead of the "template ID" in the invoice_group_pdf_template column in ip_invoice_groups

@Kovah

This comment has been minimized.

Copy link
Member

Kovah commented Feb 23, 2018

Pull request needs to be merged into a newer branch other than development as this branch is abandoned.

@kintaro1981

This comment has been minimized.

Copy link

kintaro1981 commented Feb 4, 2019

Is this been left behind from the latest IP versions?

@clockwiseq

This comment has been minimized.

Copy link

clockwiseq commented Feb 4, 2019

It's possible. We'll review it and see if we can merge it into the next release (1.5.10)

@kintaro1981

This comment has been minimized.

Copy link

kintaro1981 commented Feb 4, 2019

take a look to this too, #614 as it's related to the same feature request: #109

@clockwiseq

This comment has been minimized.

Copy link

clockwiseq commented Feb 4, 2019

Didn't mean to paste that in here. Anyway, yes, it looks like this is complete, just needs review. I'll add it to the list for the next release if we can get it reviewed by then.

@kintaro1981

This comment has been minimized.

Copy link

kintaro1981 commented Feb 4, 2019

I linked it only to make you aware it exists so you can choose what is better. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment