Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IP-1] Expenses Module #371

Closed
wants to merge 2 commits into
base: v1.5.0
from

Conversation

Projects
None yet
5 participants
@Aeolun
Copy link

Aeolun commented Jun 7, 2016

Sorry, messed up my initial pull request. Github is (more or less) new to me.

Not sure you want this in v1, but well, I needed it, so it's going to be in my branch at least 馃槂

From what I gather the intended v2 expenses module would be integrated with products, but that was beyond the scope of my need (for now).

In the end I'd like the system to be able to handle recurring expenses, so I'll work on this a bit more later. Please let me know what you think.

@Kovah

This comment has been minimized.

Copy link
Contributor

Kovah commented Jun 7, 2016

Hey! Thanks for the submission!
I will review this later, in the meantime, could you change the branch to merge this to v1.5.0? I added the branch, it's even with 1.4.7.

@Kovah Kovah added the Needs review label Jun 7, 2016

@@ -44,7 +44,7 @@
case 'testing':
case 'production':
error_reporting(0);

This comment has been minimized.

@Kovah

Kovah Jun 7, 2016

Contributor

Please revert this a error reporting should be 0 for normal apps in production.

This comment has been minimized.

@Kovah
@justjotme

This comment has been minimized.

Copy link

justjotme commented Aug 2, 2016

Is there a missing tax_rate_id in the ip_expenses table?

I had a database error then I added tax_rate_id in the ip_expenses table and it worked.

@Kovah Kovah changed the base branch from v1.4.7 to v1.4.9 Sep 29, 2016

@Kovah Kovah changed the base branch from v1.4.9 to v1.5.0 Sep 29, 2016

@Kovah Kovah closed this Oct 5, 2016

@Kovah Kovah added Declined and removed Needs review labels Jul 28, 2017

@Smuuch

This comment has been minimized.

Copy link

Smuuch commented Mar 16, 2018

Hi guys, is there anywhere we can buy the completed expense module for invoiceplane?

@chrispytorius

This comment has been minimized.

Copy link

chrispytorius commented Feb 18, 2019

I finished this module

you can get it here:
#688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.