Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for CVE-2021-29023 #733 #767

Merged
merged 4 commits into from Jul 10, 2022
Merged

Conversation

naui95
Copy link
Contributor

@naui95 naui95 commented Oct 10, 2021

Pull Request Checklist

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

implements rate limiting for:
- login attempts
- password recovery attempts
-password recovery token use
InvoicePlane#733
@@ -1 +1,6 @@
# Added for versioning
CREATE TABLE `ip_login_log` (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we rely on the table prefix here? It wouldn't always be 'ip_', right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I could see, the whole IP code base does not rely on a dynamic prefix, but always uses ip_ as prefix. All the queries I saw called the tables by passing directly ip_

@nielsdrost7 nielsdrost7 merged commit f4fe13c into InvoicePlane:develop Jul 10, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants