Do not use shell syntax to get the first remote #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| myRepo.exec(OArgv({ get: "remote." + REMOTE + ".url" }, "config"), function (err, REMOTE_URL) { | ||
| if (!REMOTE_URL) { | ||
| return Logger.log("Cannot find the remote origin url. Please add it.", "error"); |
There was a problem hiding this comment.
We have to update the error message: Cannot find the url., or something like that (maybe you have better ideas).
Thanks for this PR! 👍
There was a problem hiding this comment.
👍 Cool! Can you please add yourself incontributors?
linquize
force-pushed
the
remote.origin
branch
from
1a12d92
to
80d04d8
Compare
linquize
force-pushed
the
remote.origin
branch
from
80d04d8
to
00fe636
Compare
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it work on Windows.