Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bitbucket Server #113

Merged

Conversation

@goober
Copy link

@goober goober commented Oct 7, 2020

Add Bitbucket Server support. When this PR is completed it will solve #97

@IonicaBizau
Copy link
Owner

@IonicaBizau IonicaBizau commented Oct 8, 2020

Amazing! Thanks for this!

@goober
Copy link
Author

@goober goober commented Oct 8, 2020

@IonicaBizau it will be quite hard to detect some of the links since we cannot rely on the hostname. Have you any thoughts on a preferred approach?

@IonicaBizau
Copy link
Owner

@IonicaBizau IonicaBizau commented Oct 13, 2020

@goober Well, more tests do not hurt, but we can focus on the most common links and see when we will hit limitations with the current implementation.

Mathias Åhsberg
@goober goober force-pushed the goober:feature/parse-bitbucket-server-urls branch from f28674a to c92ee78 Oct 21, 2020
@goober goober marked this pull request as ready for review Oct 21, 2020
@goober
Copy link
Author

@goober goober commented Oct 21, 2020

@IonicaBizau The pull request is now ready for review

@goober goober changed the title Added initial tests for Bitbucket Server support Added support for Bitbucket Server Oct 21, 2020
@goober goober changed the title Added support for Bitbucket Server Add support for Bitbucket Server Oct 21, 2020
@goober goober force-pushed the goober:feature/parse-bitbucket-server-urls branch from 5f2f4da to 8d5b2bc Oct 22, 2020
Copy link
Owner

@IonicaBizau IonicaBizau left a comment

Looks good! Thank you very much.
Is it ready to be merged?

Mathias Åhsberg
@goober goober force-pushed the goober:feature/parse-bitbucket-server-urls branch from 8d5b2bc to 89098cd Oct 22, 2020
@goober
Copy link
Author

@goober goober commented Oct 22, 2020

Yes, it should be ready

@IonicaBizau IonicaBizau mentioned this pull request Oct 22, 2020
@IonicaBizau IonicaBizau merged commit 29c8460 into IonicaBizau:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.