Make our output JS less terrible. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrothenberg
requested changes
Jan 22, 2017
| const modelName = this.constructor.modelName; | ||
| const adapter = this.store.adapterFor(modelName); | ||
| return adapter.autocomplete(modelName, this.get('id'), arguments).then((response) => { | ||
| const serializer = _this.store.serializerFor(modelName); |
There was a problem hiding this comment.
is _this unnecessary now that we're using => function ?
There was a problem hiding this comment.
I'm not 100% sure the anon function works there with how Ember does things :(. Will test it out.
lib/braise/adapter_template.ex
Outdated
| var underscorized = Ember.String.underscore(type); | ||
| return Ember.String.pluralize(underscorized); | ||
| pathForType(type) { | ||
| var underscorized = EmberString.underscore(type); |
lib/braise/adapter_template.ex
Outdated
| @@ -93,7 +96,7 @@ defmodule Braise.AdapterTemplate do | |||
| action_name = link_action.name | |||
| method = link_action.method | |||
| """ | |||
| #{action_name}: function(modelName, id, snapshot) { | |||
| #{action_name}(modelName, id, snapshot) { | |||
| var url = this.buildURL(modelName, id) + '/#{action_name}'; | |||
test/adapter_template_test.exs
Outdated
| @@ -57,12 +60,15 @@ defmodule AdapterTemplateTest do | |||
| import DS from 'ember-data'; | |||
| import Ember from 'ember'; | |||
|
|
|||
| export default DS.RESTAdapter.extend({ | |||
| const { RESTAdapter } = DS; | |||
| const { computed, EmberString: String } = Ember; | |||
There was a problem hiding this comment.
I think this should be the other way
const { computed, String: EmberString } = Ember;
test/adapter_template_test.exs
Outdated
| @@ -74,7 +80,7 @@ defmodule AdapterTemplateTest do | |||
| return this._super(url, type, options); | |||
| }, | |||
|
|
|||
| cancel: function(modelName, id, snapshot) { | |||
| cancel(modelName, id, snapshot) { | |||
| var url = this.buildURL(modelName, id) + '/cancel'; | |||
There was a problem hiding this comment.
If we're ES6'ing all this should we standardize to use let or const here (& everywhere else) too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reforms our template output so it's a bit more ES6-7 compatible.