-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Capture button to IDE toolbar to update main image of Part #209
Conversation
Needs reworking to have setting the Part's image as the primary action, and to have tests written. Planning to work tonight or tomorrow (US Eastern). |
@Irev-Dev I've updated so that the toolbar has a "Set Part Image" button instead of "Capture" per Figma feedback. This is ready for your review. Pressing the button uploads and immediately overwrites whatever mainImage may have been set for the part, and then gives the user the opportunity to save a copy to their computer and shows them the image capture. This leads me to 2 questions:
Concerns
Future WorkI was unable to figure out how to automatically capture a screenshot on initial save of a Part: I need a reference to the part to complete my |
This looks really good @franknoirot 🙌 You've done a good job of figuring out the structure i.e. putting the svgs with the rest of them. I like the cloundinary helper and I think putting the capture on the cascade studio controller is the perfect place for that, and it all done in only 160 odd lines of code. Questions
Concerns
changesThat's a lot of words, here's what I think should change.
That's all really it, you can tweak the flash if you want. I'll have a bit of a look into capture on first save. 🤞 |
Woot thanks! ✨ Questions
Concerns
Will comment in after I push the update. |
I got capture on first save working. Happy for you to Note that there are some formatting changes in that commit, the project automatically formats on save for me, it's not something I set up I just think that's how redwood is setup to work when it used in vscode, I was going to ask you to run |
Oh sick @Irev-Dev way to go! Do you mind doing that in a different PR? I don't feel confident with Git yet to do a My stuff is ready for your review when you're free. I made it so that if your part happens to not have a screenshot yet when you click Save Part Image button it saves right away without needing to click the second thing as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @franknoirot.
The app is definitely a lot better because of this.
Adds a button to the CascadeStudio IDE to capture the camera view, then allows user to download the screenshot and to update the Part's main image. Related to #111 and #208. Designs can be seen in Figma. Happy to make any adjustments or edits needed!
Possible improvement could be to set up automatically saving a screenshot on first save of a Part, so all projects have a screenshot.