Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/typescript-ci-patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
# Only check coverage in one of the matrix job instances.
- op: add
path: /jobs/test/steps/7/if
value: ${{ contains(matrix.os, 'ubuntu') && matrix.node_version == '10' && matrix.rust_version == 'stable' }}
value: ${{ contains(matrix.os, 'ubuntu') && matrix.node_version == '10' && matrix.rust_version == 'stable' && github.base_ref != '' }}

# Also run on musl. That means we need to run it in a Docker container. To do that, we copy the entire job and modify its
# strategy/matrix.
Expand Down Expand Up @@ -73,3 +73,6 @@
# We don't need to run setup-node inside of a node docker image.
- op: remove
path: /jobs/test-docker/steps/4
# No need to check test coverage here, since we do it in the first matrix build.
- op: remove
path: /jobs/test-docker/steps/8
4 changes: 2 additions & 2 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.assets_url }}
upload_url: ${{ github.event.release.upload_url }}
asset_path: bin-package/${{ steps.build.outputs.asset }}
asset_name: ${{ steps.build.outputs.asset }}
asset_content_type: application/gzip
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ github.event.release.assets_url }}
upload_url: ${{ github.event.release.upload_url }}
asset_path: bin-package/${{ steps.build.outputs.asset }}
asset_name: ${{ steps.build.outputs.asset }}
asset_content_type: application/gzip
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/typescript-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
run: yarn run test
- name: Check test coverage
if: ${{ contains(matrix.os, 'ubuntu') && matrix.node_version == '10' && matrix.rust_version
== 'stable' }}
== 'stable' && github.base_ref != '' }}
uses: anuraag016/Jest-Coverage-Diff@V1.1
with:
fullCoverageDiff: false
Expand Down Expand Up @@ -82,12 +82,5 @@ jobs:
run: yarn run compile
- name: Run tests
run: yarn run test
- name: Check test coverage
if: ${{ contains(matrix.os, 'ubuntu') && matrix.node_version == '10' && matrix.rust_version
== 'stable' }}
uses: anuraag016/Jest-Coverage-Diff@V1.1
with:
fullCoverageDiff: false
delta: 0.2
container:
image: node:${{ matrix.node_version }}-alpine