New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for tests from ipy2 #353

Merged
merged 3 commits into from Nov 29, 2017

Conversation

Projects
None yet
2 participants
@slide
Member

slide commented Nov 21, 2017

No description provided.

@slozier

Does this cover the whole base Tests folder and Scripts? Or just part of it?

@slide

This comment has been minimized.

Show comment
Hide comment
@slide

slide Nov 22, 2017

Member

It is a merge of changes from the tests folder and below mostly

Member

slide commented Nov 22, 2017

It is a merge of changes from the tests folder and below mostly

@slozier

This comment has been minimized.

Show comment
Hide comment
@slozier

slozier Nov 22, 2017

Contributor

All these changes look good. I was just wondering since I know you did a bunch of renaming of tests to match the format test_xxx which I'm not seeing here.

Contributor

slozier commented Nov 22, 2017

All these changes look good. I was just wondering since I know you did a bunch of renaming of tests to match the format test_xxx which I'm not seeing here.

@slide

This comment has been minimized.

Show comment
Hide comment
@slide

slide Nov 22, 2017

Member

I think some of that was done already, are there specific files I can check?

Member

slide commented Nov 22, 2017

I think some of that was done already, are there specific files I can check?

@slozier

This comment has been minimized.

Show comment
Hide comment
@slozier

slozier Nov 22, 2017

Contributor

All these are in ipy2 but not ipy3, I assume most are renames:
Tests/functions/test_signatures.py
Tests/hosting/editor_svcs/test_errorlistener.py
Tests/hosting/editor_svcs/test_tokencategorizer.py
Tests/interop/net/dynamic/test_dynamic_regressions.py
Tests/interop/net/versions/test_four_dot_zero.py
Tests/modules/io_related/test__bytesio.py
Tests/modules/io_related/test__fileio.py
Tests/modules/io_related/test_binascii.py
Tests/modules/io_related/test_cPickle.py
Tests/modules/io_related/test_cStringIO.py
Tests/modules/io_related/test_codecs.py
Tests/modules/io_related/test_copy_reg.py
Tests/modules/io_related/test_fd.py
Tests/modules/io_related/test_io_StringIO.py
Tests/modules/io_related/test_marshal.py
Tests/modules/io_related/test_re.py
Tests/modules/misc/test__random.py
Tests/modules/misc/test__sha256.py
Tests/modules/misc/test__sha512.py
Tests/modules/misc/test__warnings.py
Tests/modules/misc/test__weakref.py
Tests/modules/misc/test_ctypes.py
Tests/modules/misc/test_datetime.py
Tests/modules/misc/test_future.py
Tests/modules/misc/test_math.py
Tests/modules/misc/test_operator.py
Tests/modules/misc/test_system_namespaces.py
Tests/modules/misc/test_zlib.py
Tests/modules/network_related/test__socket.py
Tests/modules/network_related/test__ssl.py
Tests/modules/system_related/test__locale.py
Tests/modules/system_related/test_gc.py
Tests/modules/system_related/test_nt.py
Tests/modules/system_related/test_signal.py
Tests/modules/system_related/test_sys.py
Tests/modules/system_related/test_sys_getframe.py
Tests/modules/system_related/test_thread.py
Tests/modules/system_related/test_time.py
Tests/modules/type_related/test__struct.py
Tests/modules/type_related/test_array.py
Tests/modules/type_related/test_types.py

Contributor

slozier commented Nov 22, 2017

All these are in ipy2 but not ipy3, I assume most are renames:
Tests/functions/test_signatures.py
Tests/hosting/editor_svcs/test_errorlistener.py
Tests/hosting/editor_svcs/test_tokencategorizer.py
Tests/interop/net/dynamic/test_dynamic_regressions.py
Tests/interop/net/versions/test_four_dot_zero.py
Tests/modules/io_related/test__bytesio.py
Tests/modules/io_related/test__fileio.py
Tests/modules/io_related/test_binascii.py
Tests/modules/io_related/test_cPickle.py
Tests/modules/io_related/test_cStringIO.py
Tests/modules/io_related/test_codecs.py
Tests/modules/io_related/test_copy_reg.py
Tests/modules/io_related/test_fd.py
Tests/modules/io_related/test_io_StringIO.py
Tests/modules/io_related/test_marshal.py
Tests/modules/io_related/test_re.py
Tests/modules/misc/test__random.py
Tests/modules/misc/test__sha256.py
Tests/modules/misc/test__sha512.py
Tests/modules/misc/test__warnings.py
Tests/modules/misc/test__weakref.py
Tests/modules/misc/test_ctypes.py
Tests/modules/misc/test_datetime.py
Tests/modules/misc/test_future.py
Tests/modules/misc/test_math.py
Tests/modules/misc/test_operator.py
Tests/modules/misc/test_system_namespaces.py
Tests/modules/misc/test_zlib.py
Tests/modules/network_related/test__socket.py
Tests/modules/network_related/test__ssl.py
Tests/modules/system_related/test__locale.py
Tests/modules/system_related/test_gc.py
Tests/modules/system_related/test_nt.py
Tests/modules/system_related/test_signal.py
Tests/modules/system_related/test_sys.py
Tests/modules/system_related/test_sys_getframe.py
Tests/modules/system_related/test_thread.py
Tests/modules/system_related/test_time.py
Tests/modules/type_related/test__struct.py
Tests/modules/type_related/test_array.py
Tests/modules/type_related/test_types.py

@slide

This comment has been minimized.

Show comment
Hide comment
Member

slide commented Nov 22, 2017

Show outdated Hide outdated Tests/ImportTestDir/pkg_a/__init__.py Outdated
@@ -1,124 +0,0 @@
#####################################################################################

This comment has been minimized.

@slozier

slozier Nov 24, 2017

Contributor

I probably asked this in the original PR, but why is this file getting removed? I'm not seeing a replacement.

@slozier

slozier Nov 24, 2017

Contributor

I probably asked this in the original PR, but why is this file getting removed? I'm not seeing a replacement.

This comment has been minimized.

@slide

slide Nov 25, 2017

Member

Here's the comment for when I did it in ipy2

IronLanguages/ironpython2#2 (comment)

@slide

slide Nov 25, 2017

Member

Here's the comment for when I did it in ipy2

IronLanguages/ironpython2#2 (comment)

@slozier

This comment has been minimized.

Show comment
Hide comment
@slozier
Contributor

slozier commented Nov 24, 2017

@slide

This comment has been minimized.

Show comment
Hide comment
@slide

slide Nov 26, 2017

Member

Any other feedback on this?

Member

slide commented Nov 26, 2017

Any other feedback on this?

@slide slide merged commit 8c2f3c7 into IronLanguages:master Nov 29, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@slide slide deleted the slide:test_updates branch Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment